Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Straigh line support #165

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Straigh line support #165

wants to merge 1 commit into from

Conversation

kadamski
Copy link
Contributor

This is a little hacky but at least very simple implementation of a feature requested in #59. With this change, one can get rid of the tip of the arrow by pressing ctrl key, getting straight line instead.

This is a little hacky but at least very simple implementation of a
feature requested in jtheoof#59. With this change, one can get rid of the tip
of the arrow by pressing ctrl key, getting straight line instead.
@kadamski
Copy link
Contributor Author

If you're OK with this idea, I can add appropriate documentation and whatever else is needed. If you think we should instead have a separate button for line mode, I can add make such PR instead of this one.

@jtheoof
Copy link
Owner

jtheoof commented Oct 26, 2024

Thanks for your PR. To me this is a bit too hacky. Is there any other tool that does this? (hide arrow when pressing ctrl).
Perhaps a better approach, but that would require more work, would be to have a dedicated line shape. What do you think?

@kadamski
Copy link
Contributor Author

I could make a dedicated line tool as well but I just didn't want to make the tools palette too crowded. The idea with "ctrl" came from the swappy itself as if you press "ctrl" key, the rectangle and ellipse tools work a bit differently. I'll check how it looks with dedicated button, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants