Fixed MimeParser benchmarks to dispose the messages after parsing

This reduces stress on the GC and gives us more accurate results because of that.
jstedfast · Feb 2, 2025 · b92923b · b92923b
1 parent f478fb3
commit b92923b
Showing 1 changed file with 10 additions and 6 deletions.
diff --git a/Benchmarks/MimeParserBenchmarks.cs b/Benchmarks/MimeParserBenchmarks.cs
@@ -118,6 +118,7 @@ static void MimeParserSingleMessage (string fileName, bool persistent = false)
 			using var stream = File.OpenRead (path);
 			var parser = new MimeParser (stream, MimeFormat.Entity, persistent);
 			var message = parser.ParseMessage ();
+			message.Dispose ();
 		}
 
 		[Benchmark]
@@ -140,7 +141,8 @@ static void MimeParserMboxFile (string fileName, bool persistent = false)
 			var parser = new MimeParser (stream, MimeFormat.Mbox, persistent);
 
 			while (!parser.IsEndOfStream) {
-				parser.ParseMessage ();
+				var message = parser.ParseMessage ();
+				message.Dispose ();
 			}
 		}
 
@@ -173,8 +175,8 @@ public void MimeParser_HeaderStressTest ()
 		{
 			using var stream = new MemoryStream (MessageHeaderStressTestData, false);
 			var parser = new MimeParser (stream, MimeFormat.Entity, true);
-
-			parser.ParseMessage ();
+			var message = parser.ParseMessage ();
+			message.Dispose ();
 		}
 
 		#endregion MimeParser
@@ -187,6 +189,7 @@ static void ExperimentalMimeParserSingleMessage (string fileName, bool persisten
 			using var stream = File.OpenRead (path);
 			var parser = new ExperimentalMimeParser (stream, MimeFormat.Entity, persistent);
 			var message = parser.ParseMessage ();
+			message.Dispose ();
 		}
 
 		[Benchmark]
@@ -208,7 +211,8 @@ static void ExperimentalMimeParserMboxFile (string fileName, bool persistent = f
 			var parser = new ExperimentalMimeParser (stream, MimeFormat.Mbox, persistent);
 
 			while (!parser.IsEndOfStream) {
-				parser.ParseMessage ();
+				var message = parser.ParseMessage ();
+				message.Dispose ();
 			}
 		}
 
@@ -241,8 +245,8 @@ public void ExperimentalMimeParser_HeaderStressTest ()
 		{
 			using var stream = new MemoryStream (MessageHeaderStressTestData, false);
 			var parser = new ExperimentalMimeParser (stream, MimeFormat.Entity, true);
-
-			parser.ParseMessage ();
+			var message = parser.ParseMessage ();
+			message.Dispose ();
 		}
 
 		#endregion ExperimentalMimeParser