-
Notifications
You must be signed in to change notification settings - Fork 128
Add initial config for Vercel #535
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/jsperf/jsperfcom/9pwjz15y5 |
… security issue by using @npmcorp namespace
…" when using Gulp 4
Where we are at:
|
"cloud": "v2" | ||
}, | ||
"alias": "jsperf.com", | ||
"alias": ["jsperf.com"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
alias
and name
are deprecated, they can be removed from vercel.json
Instead, you should add the production domain to your Vercel Project in the dashboard.
vercel.prod.json
Outdated
"public": true, | ||
"alias": ["jsperf.com"], | ||
"env": { | ||
"NODE_ENV": "production", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You don't need another config file here if you're only changing env vars.
Instead, use the project settings to configure different values for Preview vs Production.
https://vercel.com/blog/environment-variables-ui
Furthermore, if you are only using NODE_ENV
, for your serverless functions, then you shouldn't need to assign this at all.
…ky-markdown so hapi/lab can find it. Change .nvmrc to match new version of node for Vercel
I need jsperf, how can I help to bring it back up quickly? |
a8ff603
to
de56c7d
Compare
closes #534