Skip to content

Add initial config for Vercel #535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Sep 10, 2020
Merged

Add initial config for Vercel #535

merged 13 commits into from
Sep 10, 2020

Conversation

asilluron
Copy link
Member

@asilluron asilluron commented Aug 24, 2020

closes #534

@vercel
Copy link

vercel bot commented Aug 24, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/jsperf/jsperfcom/9pwjz15y5
✅ Preview: https://jsperfcom-git-feature-vercel.jsperf.vercel.app

@asilluron
Copy link
Member Author

Where we are at:

  • Initial Prod/Stage configs for Vercel

  • Upgrade deps to work with Node 12

  • Graceful FS pinned to work with Node 12

  • Add routes to serve correct files

"cloud": "v2"
},
"alias": "jsperf.com",
"alias": ["jsperf.com"],
Copy link

@styfle styfle Aug 27, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

alias and name are deprecated, they can be removed from vercel.json

Instead, you should add the production domain to your Vercel Project in the dashboard.

vercel.prod.json Outdated
"public": true,
"alias": ["jsperf.com"],
"env": {
"NODE_ENV": "production",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't need another config file here if you're only changing env vars.

Instead, use the project settings to configure different values for Preview vs Production.

https://vercel.com/blog/environment-variables-ui

Furthermore, if you are only using NODE_ENV, for your serverless functions, then you shouldn't need to assign this at all.

…ky-markdown so hapi/lab can find it. Change .nvmrc to match new version of node for Vercel
@L3P3
Copy link

L3P3 commented Sep 4, 2020

I need jsperf, how can I help to bring it back up quickly?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[IMPORTANT] Migrate from Zeit 1.0 config to Vercel config
4 participants