Skip to content

Migrate AmbassadorsCard, AmbassadorsBanner and AmbassadorsList to ShadCN +2 issues resolved #1731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

idanidan29
Copy link
Collaborator

What kind of change does this PR introduce?

  • Adapted 3 components to use the ShadCN library.
  • Created and adjusted Cypress test files for these 3 components
  • Added animation to the ambassador card when pressing on the 'full details' button.
  • standardized all the image sizes on the ambassadors card

Issue Number:

Screenshots/videos:

Screen.Recording.2025-06-22.183916.mp4

The banner and list components look completely the same.

Summary

This PR:

  • Migrated the existing AmbassadorsCard.tsx, AmbassadorsBanner .tsx, and AmbassadorsList components to the ShadCN library.
  • Enhanced the overall styling (mainly small color theme and light mode changes).
  • Added Cypress tests for all implemented components to ensure reliability and behavior coverage.
  • solved 2 issues as related to phase 2:
    • animations on the 'full details' button.
    • standardized all the image sizes on the ambassadors card

Does this PR introduce a breaking change?

no

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@idanidan29 idanidan29 requested a review from a team as a code owner June 22, 2025 15:41
@idanidan29 idanidan29 added the GSoC Google Summer of Code related label Jun 22, 2025
Copy link

github-actions bot commented Jun 22, 2025

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
website ✅ Ready (View Log) Visit Preview 0e0bd2e

Copy link

codecov bot commented Jun 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (547dcf2) to head (0e0bd2e).

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1731   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           18        22    +4     
  Lines          448       499   +51     
  Branches       116       142   +26     
=========================================
+ Hits           448       499   +51     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GSoC Google Summer of Code related
Projects
Status: Ready to review
Development

Successfully merging this pull request may close these issues.

Adding animation to button when user click on see full details button 🐛 Bug: Standardize ambassadors Image Sizes
1 participant