Skip to content

Migrate Button, Radio, and DropdownMenu to ShadCN and Add Tests +3 issues resolved #1709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 34 commits into
base: main
Choose a base branch
from

Conversation

idanidan29
Copy link
Collaborator

@idanidan29 idanidan29 commented Jun 14, 2025

What kind of change does this PR introduce?

  • Adapted 3 components to use the ShadCN library.
  • Created and adjusted Cypress test files for these 3 components and for the shadCN card element to ensure reliability and behavior coverage.
  • While adapting the components, utilized ShadCN's Button ,Radio and Collapsible elements.
  • Added hover effects to the sections in the tools filter.
  • Added a counter to each section indicating the number of active filters in use.

Issue Number:

Screenshots/videos:

Screen.Recording.2025-06-14.234317.mp4

The Radio component was not being used at the moment but still have been adapted to ShadCN for future use.

Summary

This PR:

  • Migrated the existing Button.tsx, Radio.tsx, and DropdownMenu components to the ShadCN library.
  • Enhanced the styling of the button component to improve dark mode compatibility (open to feedback).
  • Added Cypress tests for all implemented components to ensure reliability and behavior coverage.
  • solved 3 issues as related to phase 1:
    • Hover effects for better interactivity.
    • A visual counter showing the number of active filters per section.
    • fixed the checkbox icon to the middle

Does this PR introduce a breaking change?

no

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@idanidan29 idanidan29 requested a review from a team as a code owner June 14, 2025 20:45
@idanidan29 idanidan29 added the GSoC Google Summer of Code related label Jun 14, 2025
Copy link

github-actions bot commented Jun 14, 2025

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
website ✅ Ready (View Log) Visit Preview 66af35d

Copy link

codecov bot commented Jun 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (1ac0817) to head (66af35d).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1709   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           18        23    +5     
  Lines          448       477   +29     
  Branches       116       122    +6     
=========================================
+ Hits           448       477   +29     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@idanidan29 idanidan29 changed the title Migrate Button, Radio, and DropdownMenu Components to ShadCN and Add Tests +2 issues Migrate Button, Radio, and DropdownMenu to ShadCN and Add Tests +2 issues resolved Jun 14, 2025
@Utkarsh-123github Utkarsh-123github moved this from Unclear to Ready to review in PR - Triage Group Jun 16, 2025
Copy link
Collaborator

@benjagm benjagm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work Idan. I just found some weird behaviours in the clear filters button. We need to review the logic to make sure whe are clearing all the field selections after clicking the clear filter button.

@idanidan29 idanidan29 changed the title Migrate Button, Radio, and DropdownMenu to ShadCN and Add Tests +2 issues resolved Migrate Button, Radio, and DropdownMenu to ShadCN and Add Tests +3 issues resolved Jun 20, 2025
@idanidan29 idanidan29 requested a review from benjagm June 20, 2025 11:01
@idanidan29
Copy link
Collaborator Author

idanidan29 commented Jun 20, 2025

@benjagm I've adjusted the clean filters logic, fixed the issue mentioned in #1724, and added tests to ensure correct sizing and placement of the checkbox icon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GSoC Google Summer of Code related
Projects
Status: Ready to review
2 participants