-
-
Notifications
You must be signed in to change notification settings - Fork 281
Migrate Button, Radio, and DropdownMenu to ShadCN and Add Tests +3 issues resolved #1709
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1709 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 18 23 +5
Lines 448 477 +29
Branches 116 122 +6
=========================================
+ Hits 448 477 +29 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work Idan. I just found some weird behaviours in the clear filters button. We need to review the logic to make sure whe are clearing all the field selections after clicking the clear filter button.
What kind of change does this PR introduce?
Button
,Radio
andCollapsible
elements.Issue Number:
Screenshots/videos:
Screen.Recording.2025-06-14.234317.mp4
Summary
This PR:
Button.tsx
,Radio.tsx
, andDropdownMenu
components to the ShadCN library.button
component to improve dark mode compatibility (open to feedback).Does this PR introduce a breaking change?
no
Checklist
Please ensure the following tasks are completed before submitting this pull request.