-
-
Notifications
You must be signed in to change notification settings - Fork 260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Polish docs #1603
base: main
Are you sure you want to change the base?
Polish docs #1603
Conversation
Hey @izeye , cau you please provide more detail about this PR , not able to understand what you're trying to resolve. |
@jagpreetrahi It's just a missing punctuation mark between the sentence and the next code block like the following in the same Markdown file: website/pages/understanding-json-schema/basics.md Lines 50 to 55 in b0c67bd
|
Can you please mention the issue number also |
@jagpreetrahi I didn't create an issue for it. I'm not sure if it's worth it as it's just a small and obvious fix. |
@izeye , as we begin contributing, it's natural to feel excited to merge PRs. However, the standard practice is to first create an issue (if one doesn't already exist), wait for it to be accepted, and then open a PR. This approach helps maintain clarity and coordination within the project. Thanks |
@jagpreetrahi I just created this PR through the "Edit this page on Github" link on the website, so I hoped it's okay as-is. Thanks for the feedback, but I'll wait for maintainers' feedback as I don't want to make any more noise here due to this small fix. |
What kind of change does this PR introduce?
This PR adds a missing ending colon in the
basics.md
.Issue Number:
N/A
Screenshots/videos:
N/A
If relevant, did you update the documentation?
N/A
Summary
N/A
Does this PR introduce a breaking change?
N/A
Checklist
Please ensure the following tasks are completed before submitting this pull request.