Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add animations into ambassordors card #1570

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add animations into ambassordors card #1570

wants to merge 2 commits into from

Conversation

AQIB-NAWAB
Copy link
Contributor

What kind of change does this PR introduce?
refactoring

Issue Number:

Screenshots/videos:
Screencast from 2025-03-19 20-23-49.webm

Summary
Adding smooth animations will improve user experience.

Does this PR introduce a breaking change?
NO

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@AQIB-NAWAB AQIB-NAWAB requested a review from a team as a code owner March 19, 2025 15:24
@AQIB-NAWAB
Copy link
Contributor Author

@DhairyaMajmudar @benjagm , Please review the PR

@DhairyaMajmudar DhairyaMajmudar self-requested a review March 22, 2025 16:07
@AQIB-NAWAB
Copy link
Contributor Author

Hi @DhairyaMajmudar please review the PR

@DhairyaMajmudar
Copy link
Member

Thanks for the PR @AQIB-NAWAB can you pls. share some screenshots and video recording demonstrating your changes.

@AQIB-NAWAB
Copy link
Contributor Author

Sure @DhairyaMajmudar

Here is current behavior
Screencast from 2025-03-24 20-15-27.webm

Suggested Behavior
Screencast from 2025-03-19 20-23-49.webm

DhairyaMajmudar
DhairyaMajmudar requested changes Mar 24, 2025
View reviewed changes
Copy link
Member

@DhairyaMajmudar DhairyaMajmudar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awsm PR @AQIB-NAWAB, overall it looks good, few comments.

@AQIB-NAWAB
Copy link
Contributor Author

Awsm PR @AQIB-NAWAB, overall it looks good, few comments.

Thanks @DhairyaMajmudar , I have made suggested changes. Please let me know if there is any issue remains , I’d love to contribute further. Thanks!

DhairyaMajmudar
DhairyaMajmudar approved these changes Mar 27, 2025
View reviewed changes
Copy link
Member

@DhairyaMajmudar DhairyaMajmudar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is working good 👍🏻

@AQIB-NAWAB
Copy link
Contributor Author

@benjagm Please review the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DhairyaMajmudar DhairyaMajmudar DhairyaMajmudar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Adding animation to button when user click on see full details button
2 participants
@AQIB-NAWAB @DhairyaMajmudar