Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Counter to dropdown menu in tools Page #1479

Open
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

AQIB-NAWAB
Copy link
Contributor

@AQIB-NAWAB AQIB-NAWAB commented Mar 8, 2025

What kind of change does this PR introduce?

feature
Issue Number:

Screenshots/videos:

image

Summary
Add a counter to each dropdown which increase the user experience to see the total numbers of selected filter in each dropdown.

Does this PR introduce a breaking change?
No. There is nothing

@AQIB-NAWAB AQIB-NAWAB requested a review from a team as a code owner March 8, 2025 19:30
Copy link

github-actions bot commented Mar 8, 2025

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
website ✅ Ready (View Log) Visit Preview 4f218f7

Copy link

codecov bot commented Mar 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (a44dbdf) to head (4f218f7).

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1479   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines          396       396           
  Branches       106       106           
=========================================
  Hits           396       396           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@AQIB-NAWAB
Copy link
Contributor Author

Hi @benjagm , please review the PR

Copy link
Member

@DhairyaMajmudar DhairyaMajmudar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AQIB-NAWAB Thanks for PR pls. check my review comments

@AQIB-NAWAB
Copy link
Contributor Author

@DhairyaMajmudar Please review the PR

@DhairyaMajmudar
Copy link
Member

The border around the number is not full circle

Screenshot from 2025-03-10 20-04-10

The changes are not optimal with light mode

image

@AQIB-NAWAB
Copy link
Contributor Author

AQIB-NAWAB commented Mar 10, 2025

@DhairyaMajmudar is it good under light mode ??

image

@AQIB-NAWAB
Copy link
Contributor Author

Hi @DhairyaMajmudar , please review the PR

@AQIB-NAWAB
Copy link
Contributor Author

AQIB-NAWAB commented Mar 14, 2025

Hi @benjagm , Please review the PR.
Thanks

Copy link

Hi @AQIB-NAWAB! Thanks a lot for your contribution!

I noticed that the following required information is missing or incomplete: breaking changes information

Please update the PR description to include this information. You can find placeholders in the PR template for these items.

Thanks a lot!

Copy link

Hi @AQIB-NAWAB! Thanks a lot for your contribution!

I noticed that the following required information is missing or incomplete: breaking changes information

Please update the PR description to include this information. You can find placeholders in the PR template for these items.

Thanks a lot!

Copy link

Hi @AQIB-NAWAB! Thanks a lot for your contribution!

I noticed that the following required information is missing or incomplete: breaking changes information

Please update the PR description to include this information. You can find placeholders in the PR template for these items.

Thanks a lot!

@AQIB-NAWAB
Copy link
Contributor Author

Here is the video of output:

Screencast.from.2025-03-16.15-44-57.webm

Working on mobile as well
image

Please let me know if there anything need to improved 😊

Thanks

@AQIB-NAWAB
Copy link
Contributor Author

Hi @benjagm , Please review the PR

Copy link
Member

@DhairyaMajmudar DhairyaMajmudar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

Copy link
Member

@DarhkVoyd DarhkVoyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, sorry I missed the discussion. I’m not a big fan of this design or how it’s implemented. I don’t understand how this metric is helpful or useful. I do like the idea of making it more intuitive for users to see the filters they’ve selected. Have you thought about some alternatives? I think badges or tags might be a better idea.
Screenshot 2025-03-23 at 10 08 18 PM

@AQIB-NAWAB
Copy link
Contributor Author

AQIB-NAWAB commented Mar 24, 2025

Hey, sorry I missed the discussion. I’m not a big fan of this design or how it’s implemented. I don’t understand how this metric is helpful or useful. I do like the idea of making it more intuitive for users to see the filters they’ve selected. Have you thought about some alternatives? I think badges or tags might be a better idea. Screenshot 2025-03-23 at 10 08 18 PM

Hi @DarhkVoyd , currently, there are a lot of options in the filter section that do not align with the suggested design.

The reason for adding a counter in the dropdown menus is that when users search with filters, all dropdowns collapse, requiring them to check again which options were selected. Showing the counter in the dropdown is a good way to enhance user engagement.

Here is video of current behavior
Screencast from 2025-03-24 10-17-49.webm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

✨ Enhancement: Display Selected Filter Count as Badges on Filter Dropdowns
3 participants