-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert to Eleventy. #836
base: main
Are you sure you want to change the base?
Convert to Eleventy. #836
Conversation
- Copy and ignore files as needed. - Comment out old `prettify.css` usage. - Move `learn.html` to `learn/index.html` and update links. This could break external links, but is aligned with the pattern of other files and dirs. Eleventy will put it in `learn/` by default either way without an override. - `specs/`, `primer/`, and `requirements/`: - Generate sub-dir listing data with JS. - Switch from PHP to LiquidJS.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for work on this, Dave! Most of the space the minutes consume is due to audio captures of the early meetings, which we haven’t kept going in some time. Do logs indicate if they’re ever actually accessed? Maybe there’s a way to move those someplace else off of the main (or minutes) site.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At last!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great overall. Just some non-blocking recommendations.
eleventyConfig.ignores.add('presentations'); | ||
eleventyConfig.ignores.add('scripts'); | ||
eleventyConfig.ignores.add('spec/tools'); | ||
eleventyConfig.ignores.add('spec/LICENSE.md'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These ignores can be moved to .eleventyignore
to make this file more sane.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's wrong with having them here? At least for now. It's a bit confusing as is due to eleventy processing various things, having to pass through others, and ignore particular files. And for drafts, that's done computationally. I thought it made more sense to keep the details in one place.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I get the single place to look. I mostly just like data in inert places whenever possible vs. buried among API calls.
Deploying json-ld-org with
|
Latest commit: |
eac8e81
|
Status: | ✅ Deploy successful! |
Preview URL: | https://f886401a.json-ld-org.pages.dev |
- Convert README from reStructuredText to Markdown. - The reStructuredText format still works, and was a fine choice back in 2010(!) but Markdown is more common for READMEs like this today.
- Add `404.html` for Cloudflare Pages.
Another issue with this conversion is how to handle all the
And while pondering these things, I'm wondering where this is headed.
|
@davidlehn per your concerns above, I think we can keep using 11ty separate from the hosting platform. Having 11ty in place makes working on (and redesigning) the site much simpler--where it's hosted can be a separate matter because 11ty generates static sites. Cloudflare hosting can easily get more complex/tangled (just like the build tool nightmare that is modern JavaScript vs. ye olde All that to say, how this is hosted is orthogonal to using 11ty. |
@davidlehn how close do you think this is to shippable? I know #840 is part of the consideration here too. Just curious how we can get this over the finish line. Since the WG is getting rechartered, it'd be super to get this in a space we can continue to improve, redesign, etc. Happy to help finish it off...just not sure where we're stuck. |
- Remove PHP proxy code. - Move proxy URL to /playground/proxy. - Use eleventy@3 alpha for `onRequset` dev server support. - Add Eleventy dev server `onRequest` proxy to local wrangler server proxy. Due to current limited API, emulate a basic playground request. - Reimplement proxy as a Cloudflare Pages Function. - Basic proxy designed for limited use and abuse. - Add various checks to limit useful scope. - Update README. - Ignore .wrangler.
To untangle this, I've added a
I don't think we should do this as it'd be a good deal of overhead to maintain/juggle both. Consequently, I've removed the Once #855 is merged into this PR, I think this one can be marked "ready for review", and we can get a preview URL on Cloudflare sporting all the things for further testing from everyone here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My earlier concerns were due to misinterpreting Markdown. They're resolved
Status:
Issues:
minutes/
. It's gigantic and inappropriate to mix into a static site directly.Notes:
Testing:
npm install npm run serve # open http://localhost:8080/ (or whatever URL it gives you)