Skip to content

Mark 1.1 tests with "specVersion": "1.1", which is independent of "processingMode". #518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 11, 2017

Conversation

gkellogg
Copy link
Member

Update test vocabulary location to be https. Add specVersion.

Fixes #489.

@gkellogg gkellogg requested review from davidlehn and dlongley July 10, 2017 21:24
@gkellogg
Copy link
Member Author

@davidlehn Please see if this allows you to run the test suite against an unmodified processor. It mostly does for me; basically look for (options.specVersion || "1.0") === "1.0".

@davidlehn
Copy link
Member

This works. Thanks.

Would it make sense to align processingMode and specVersion both as "json-ld-1.1"? Probably not that big a deal since this is just testing framework naming.

@gkellogg gkellogg merged commit f483b30 into master Jul 11, 2017
@gkellogg gkellogg deleted the issue-489 branch July 11, 2017 15:41
@gkellogg gkellogg added this to the JSON-LD 1.1 milestone Oct 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants