-
-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multi-target against .NET 9 RC2 #1550
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1550 +/- ##
=======================================
Coverage 90.73% 90.73%
=======================================
Files 353 353
Lines 11492 11492
Branches 1888 1888
=======================================
Hits 10427 10427
Misses 696 696
Partials 369 369 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
dedc89f
to
e7ce58b
Compare
6da1d24
to
2bec731
Compare
e1aa16a
to
c5d0800
Compare
Hi - is there a preview Nuget of this anywhere we can try against our own code? |
I don't think there's a need for that. EF Core 9 targets .NET 8, so the current JADNC version should work already with EF Core 9 on both .NET 8 and 9. |
I've created #1619 to verify all tests are green when running on .NET 9 RC2 with EF Core 9 RC2, while still referencing JADNC that targets only .NET 8 and 6. While there are breaking changes in the EF Core driver API (so you'll need matching versions for PostgreSQL, MySQL, SQL Server, etc.), it appears that JADNC itself is already compatible. This means we don't need to release a new version of JADNC when .NET 9 ships. |
4a11709
to
8b76268
Compare
8b76268
to
978c53b
Compare
978c53b
to
45490a7
Compare
45490a7
to
d7ff06d
Compare
Explores multi-targeting against .NET 9 with EF Core 9 pre-release versions. Based on #1619.
Caution
This PR is experimental and not intended to be merged.
Blocked by:
Regression in .NET 9 RC2: NU1605 Downgrade error which isn't a downgrade NuGet/Home#13855Split query with AsNoTrackingWithIdentityResolution() throws ArgumentOutOfRangeException dotnet/efcore#34728https://youtrack.jetbrains.com/issue/RSRP-498478/Breaking-primary-constructors-with-readonly-fieldNullReferenceException from CSharpPreferGenericOverloadsAnalyzer in .NET 9 RC1 dotnet/roslyn-analyzers#7421