Fix tests

.azure-pipelines/templates/automation_test.yml

@@ -0,0 +1,53 @@
+# Azure DevOps task for automation test using azdev and pytest
+
+parameters:
+- name: pythonVersion
+  type: string
+  default: 3.8
+- name: profile
+  type: string
+  default: latest
+- name: fullTest
+  displayName: Run full test?
+  type: boolean
+  default: false
+- name: module
+  displayName: Run test for specific module
+  type: string
+  default: ''
+
+steps:
+  - task: UsePythonVersion@0
+    inputs:
+      versionSpec: ${{ parameters.pythonVersion }}
+      displayName: "Use Python ${{ parameters.pythonVersion }}"
+  - template: ./azdev_setup.yml
+  - bash: |
+      set -ev
+
+      source env/bin/activate
+
+      echo pythonVersion: ${{ parameters.pythonVersion }}
+      echo profile: ${{ parameters.profile }}
+      echo fullTest: ${{ parameters.fullTest }}
+      echo module: ${{ parameters.module }}
+      echo Build.Reason: $(Build.Reason)
+
+      # Test specific module
+      module="${{ parameters.module }}"
+      if [[ -n $module ]]; then
+        echo "Running test for module '$module'"
+        azdev test --no-exitfirst --verbose --series $module
+        exit 0
+      fi
+
+      if [[ "$(Build.Reason)" == "PullRequest" && "${{ parameters.fullTest }}" == 'False' ]]; then
+        echo "Running incremental test"
+        azdev test --no-exitfirst --repo=./ --src=HEAD --tgt=origin/$(System.PullRequest.TargetBranch) --cli-ci --profile ${{ parameters.profile }} --verbose --series
+      else
+        echo "Running full test"
+        azdev test --no-exitfirst --profile ${{ parameters.profile }} --verbose --series
+      fi
+    displayName: "azdev test"
+    env:
+      ADO_PULL_REQUEST_LATEST_COMMIT: $(System.PullRequest.TargetBranch)

.azure-pipelines/templates/azdev_setup.yml

@@ -0,0 +1,29 @@
+parameters:
+  - name: CLIRepoPath
+    type: string
+    default: '.'
+  - name: CLIExtensionRepoPath
+    type: string
+    default: ''
+steps:
+  - bash: |
+      set -ev
+
+      python -m venv env
+      chmod +x env/bin/activate
+      . env/bin/activate
+      python -m pip install -U pip
+      pip install azdev==0.1.32
+      azdev --version
+
+      if [ -z "$CLI_EXT_REPO_PATH" ]; then
+        azdev setup -c $CLI_REPO_PATH --debug
+      else
+        azdev setup -c $CLI_REPO_PATH -r $CLI_EXT_REPO_PATH --debug
+      fi
+      # This helps detect issues in CI if a used SDK API version is deleted by the below script.
+      python $CLI_REPO_PATH/build_scripts/windows/scripts/remove_unused_api_versions.py
+    displayName: 'azdev setup'
+    env:
+      CLI_REPO_PATH: ${{ parameters.CLIRepoPath }}
+      CLI_EXT_REPO_PATH: ${{ parameters.CLIExtensionRepoPath }}

.dockerignore

@@ -12,5 +12,8 @@
 !LICENSE.txt
 # Exclude build droppings, as mentioned in .gitignore
 src/build*
+# Exclude tests
+src/azure-cli/azure/cli/command_modules/*/tests
+# Exclude python cache
 **/*.pyc
 **/__pycache__

.flake8

@@ -8,11 +8,15 @@ ignore =
     F811,  # redefinition of unused, to be removed in the future
     C901   # code flow is too complex, too many violations, to be removed in the future
     W504   # line break after binary operator effect on readability is subjective
-exclude = 
+per-file-ignores =
+    # module level import not at top of file, elevate timer to measure import time
+    src/azure-cli/azure/cli/__main__.py:E402
+exclude =
     azure_bdist_wheel.py
     build
     tools
     scripts
     doc
     build_scripts
-	*/grammar/
+    */grammar/
+    vendored_sdks

.gitattributes

@@ -11,3 +11,7 @@
 
 # Some Windows-specific files should always be CRLF
 *.bat eol=crlf
+# The az script for Git Bash/Cygwin should be LF
+build_scripts/windows/scripts/az eol=lf
+# sh scripts should be LF
+*.sh eol=lf

.github/CODEOWNERS

@@ -1,39 +1,60 @@
 # See for instructions on this file https://help.github.com/articles/about-codeowners/
 
-*help.py @sptramer @Juliehzl
-*help.yaml @sptramer @Juliehzl
-*help.yml  @sptramer @Juliehzl
+*help.py @msyyc @jiasli @jsntcy
+*help.yaml @msyyc @jiasli @jsntcy
+*help.yml @msyyc @jiasli @jsntcy
 
-/tools/ @zikalino
-/scripts/ @zikalino
-/src/azure-cli-testsdk/ @zikalino
-/src/azure-cli-core/ @yugangw-msft
-/src/azure-cli/azure/cli/command_modules/acr/ @djyou
-/src/azure-cli/azure/cli/command_modules/acs/ @rjtsdl
+/linter_exclusions.yml @jsntcy @kairu-ms
+
+/doc/ @jiasli @qwordy @dbradish-microsoft
+/tools/ @fengzhou-msft @jiasli
+/scripts/ @fengzhou-msft @jiasli
+/scripts/live_test @qwordy
+/src/azure-cli-testsdk/ @jsntcy @jiasli @kairu-ms @qwordy
+/src/azure-cli-core/ @jiasli @Juliehzl @fengzhou-msft @evelyn-ys @jsntcy @houk-ms
+/src/azure-cli-core/azure/cli/core/extension/ @msyyc @fengzhou-msft
+/src/azure-cli-core/azure/cli/core/_profile.py @jiasli @evelyn-ys
+/src/azure-cli-core/azure/cli/core/adal_authentication.py @jiasli @evelyn-ys
+/src/azure-cli-core/azure/cli/core/msal_authentication.py @jiasli @evelyn-ys
+/src/azure-cli-core/azure/cli/core/style.py @jiasli @evelyn-ys @zhoxing-ms
+/src/azure-cli/azure/cli/command_modules/acr/ @fengzhou-msft @yungezz @northtyphoon @rosanch
+/src/azure-cli/azure/cli/command_modules/acs/ @fengzhou-msft @zqingqing1 @gtracer @xizhamsft @andyliuliming
 /src/azure-cli/azure/cli/command_modules/advisor/ @Prasanna-Padmanabhan
-/src/azure-cli/azure/cli/command_modules/appservice/ @qwordy
-/src/azure-cli/azure/cli/command_modules/backup/ @dragonfly91
-/src/azure-cli/azure/cli/command_modules/batch/ @bgklein
+/src/azure-cli/azure/cli/command_modules/apim/ @kevinhillinger @jonlester
+/src/azure-cli/azure/cli/command_modules/appconfig/ @shenmuxiaosen @avanigupta @qwordy
+/src/azure-cli/azure/cli/command_modules/appservice/ @qwordy @Juliehzl
+/src/azure-cli/azure/cli/command_modules/aro/ @mjudeikis @jim-minter
+/src/azure-cli/azure/cli/command_modules/backup/ @dragonfly91 @fengzhou-msft @qwordy @akshayneema
+/src/azure-cli/azure/cli/command_modules/batch/ @bgklein @gingi @dpwatrous @paterasMSFT @qwordy
 /src/azure-cli/azure/cli/command_modules/batchai/ @AlexanderYukhanov
-/src/azure-cli/azure/cli/command_modules/cosmosdb/ @dmakwana
-/src/azure-cli/azure/cli/command_modules/cloud/ @jiasli
-/src/azure-cli/azure/cli/command_modules/container/ @samkreter
+/src/azure-cli/azure/cli/command_modules/cloud/ @jiasli @fengzhou-msft @Juliehzl
 /src/azure-cli/azure/cli/command_modules/consumption/ @sandeepnl
-/src/azure-cli/azure/cli/command_modules/dls/ @lewu-msft
-/src/azure-cli/azure/cli/command_modules/eventgrid/ @kalyanaj
-/src/azure-cli/azure/cli/command_modules/extension/ @zikalino
-/src/azure-cli/azure/cli/command_modules/keyvault/ @jiasli
-/src/azure-cli/azure/cli/command_modules/monitor/ @MyronFanQiu
-/src/azure-cli/azure/cli/command_modules/natgateway/ @khannarheams
-/src/azure-cli/azure/cli/command_modules/network/ @MyronFanQiu
-/src/azure-cli/azure/cli/command_modules/policyinsights/ @cheggert
-/src/azure-cli/azure/cli/command_modules/profile/ @jiasli
-/src/azure-cli/azure/cli/command_modules/resource/ @Juliehzl
-/src/azure-cli/azure/cli/command_modules/role/ @jiasli
-/src/azure-cli/azure/cli/command_modules/storage/ @Juliehzl
-/src/azure-cli/azure/cli/command_modules/servicefabric/ @QingChenmsft
-/src/azure-cli/azure/cli/command_modules/sql/ @jaredmoo
-/src/azure-cli/azure/cli/command_modules/vm/ @qwordy
+/src/azure-cli/azure/cli/command_modules/container/ @zhoxing-ms @fengzhou-msft
+/src/azure-cli/azure/cli/command_modules/cosmosdb/ @dmakwana @kristynhamasaki @Juliehzl
+/src/azure-cli/azure/cli/command_modules/databoxedge/ @evelyn-ys @Juliehzl
+/src/azure-cli/azure/cli/command_modules/dls/ @akharit @rahuldutta90 @Juliehzl @jsntcy
+/src/azure-cli/azure/cli/command_modules/dms/ @temandr @binuj
 /src/azure-cli/azure/cli/command_modules/eventhubs/ @v-ajnava
-/src/azure-cli/azure/cli/command_modules/servicebus/ @v-ajnava
-/src/azure-cli/azure/cli/command_modules/apim/ @kevinhillinger @jonlester
+/src/azure-cli/azure/cli/command_modules/eventgrid/ @Juliehzl @evelyn-ys @VidyaKukke
+/src/azure-cli/azure/cli/command_modules/extension/ @fengzhou-msft @msyyc
+/src/azure-cli/azure/cli/command_modules/feedback/ @fengzhou-msft @jiasli
+/src/azure-cli/azure/cli/command_modules/hdinsight/ @aim-for-better @Juliehzl @kairu-ms
+/src/azure-cli/azure/cli/command_modules/iot/ @digimaun
+/src/azure-cli/azure/cli/command_modules/keyvault/ @fengzhou-msft @yungezz @houk-ms
+/src/azure-cli/azure/cli/command_modules/monitor/ @msyyc @jsntcy @kairu-ms
+/src/azure-cli/azure/cli/command_modules/natgateway/ @khannarheams @jsntcy @kairu-ms @msyyc
+/src/azure-cli/azure/cli/command_modules/network/ @jsntcy @kairu-ms @msyyc
+/src/azure-cli/azure/cli/command_modules/policyinsights/ @cheggert
+/src/azure-cli/azure/cli/command_modules/privatedns/ @jsntcy @kairu-ms @msyyc
+/src/azure-cli/azure/cli/command_modules/profile/ @jiasli @evelyn-ys @fengzhou-msft
+/src/azure-cli/azure/cli/command_modules/rdbms/ @arde0708 @Juliehzl @evelyn-ys
+/src/azure-cli/azure/cli/command_modules/resource/ @Juliehzl @zhoxing-ms
+/src/azure-cli/azure/cli/command_modules/role/ @jiasli @evelyn-ys @jsntcy @fengzhou-msft
+/src/azure-cli/azure/cli/command_modules/search/ @huangbolun @kairu-ms
+/src/azure-cli/azure/cli/command_modules/servicebus/ @v-ajnava @fengzhou-msft
+/src/azure-cli/azure/cli/command_modules/servicefabric/ @QingChenmsft @qwordy
+/src/azure-cli/azure/cli/command_modules/sql/ @jaredmoo @Juliehzl @evelyn-ys
+/src/azure-cli/azure/cli/command_modules/storage/ @Juliehzl @jsntcy @zhoxing-ms @evelyn-ys
+/src/azure-cli/azure/cli/command_modules/synapse/ @idear1203 @sunsw1994 @aim-for-better
+/src/azure-cli/azure/cli/command_modules/util/ @jiasli @Juliehzl @zhoxing-ms @evelyn-ys
+/src/azure-cli/azure/cli/command_modules/vm/ @qwordy @houk-ms @yungezz

.github/ISSUE_TEMPLATE/Bug_report.md

@@ -10,16 +10,16 @@ assignees: ''
 > ### `az feedback` auto-generates most of the information requested below, as of CLI version 2.0.62
 
 **Describe the bug**
-A clear and concise description of what the bug is.
+<!--- A clear and concise description of what the bug is. --->
 
 **To Reproduce**
-Steps to reproduce the behavior.
+<!--- Steps to reproduce the behavior. --->
 
 **Expected behavior**
-A clear and concise description of what you expected to happen.
+<!--- A clear and concise description of what you expected to happen. --->
 
 **Environment summary**
-Install Method (e.g. pip, interactive script, apt-get, Docker, MSI, edge build) / CLI version (`az --version`) / OS version / Shell Type (e.g. bash, cmd.exe, Bash on Windows)  
+<!--- Install Method (e.g. pip, interactive script, apt-get, Docker, MSI, edge build) / CLI version (`az --version`) / OS version / Shell Type (e.g. bash, cmd.exe, Bash on Windows)  --->
 
 **Additional context**
-Add any other context about the problem here.
+<!--- Add any other context about the problem here. --->

.github/ISSUE_TEMPLATE/Feature_request.md

@@ -8,13 +8,13 @@ assignees: ''
 ---
 
 **Is your feature request related to a problem? Please describe.**
-A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
+<!--- A clear and concise description of what the problem is. Ex. I'm always frustrated when [...] --->
 
 **Describe the solution you'd like**
-A clear and concise description of what you want to happen.
+<!--- A clear and concise description of what you want to happen. --->
 
 **Describe alternatives you've considered**
-A clear and concise description of any alternative solutions or features you've considered.
+<!--- A clear and concise description of any alternative solutions or features you've considered. --->
 
 **Additional context**
-Add any other context or screenshots about the feature request here.
+<!--- Add any other context or screenshots about the feature request here. --->

.github/ISSUE_TEMPLATE/Service_team_request.md

@@ -9,17 +9,17 @@ assignees: ''
 ---
 
 **Resource Provider**
-What is the Azure resource provider your feature is part of?
+<!--- What is the Azure resource provider your feature is part of? --->
 
 **Description of Feature or Work Requested**
-Provide a brief description of the feature or work requested. A link to conceptual documentation may be helpful too.
+<!--- Provide a brief description of the feature or work requested. A link to conceptual documentation may be helpful too. --->
 
 **Minimum API Version Required**
-What is the minimum API version of your service required to implement your feature?
+<!--- What is the minimum API version of your service required to implement your feature? --->
 
 **Swagger Link**
-Provide a link to the location of your feature(s) in the REST API specs repo. If your feature(s) has corresponding commit or pull request in the REST API specs repo, provide them. This should be on the master branch of the REST API specs repo.
+<!--- Provide a link to the location of your feature(s) in the REST API specs repo. If your feature(s) has corresponding commit or pull request in the REST API specs repo, provide them. This should be on the master branch of the REST API specs repo. --->
 
 **Target Date**
-If you have a target date for release of this feature/work, please provide it. While we can't guarantee these dates,
-it will help us prioritize your request against other requests.
+<!--- If you have a target date for release of this feature/work, please provide it. While we can't guarantee these dates,
+it will help us prioritize your request against other requests. --->

.github/pull_request_template.md

@@ -1,9 +1,21 @@
+**Description**<!--Mandatory-->
+<!--Why this PR? What is changed? What is the effect? etc. A high-quality description can accelerate the review process.-->
 
+**Testing Guide**
+<!--Example commands with explanations.-->
+
+**History Notes**
+<!--If your PR is not customer-facing, use {Component Name} in the PR title. Otherwise, use [Component Name] to allow our pipeline to add the title as a history note. If you need multiple history notes or would like to overwrite the note from the PR title, please fill in the following templates.-->
+
+[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change.
+[Component Name 2] az command b: Add some customer-facing feature.
 
 ---
 
 This checklist is used to make sure that common guidelines for a pull request are followed.
 
-- [ ] The PR has modified HISTORY.rst describing any customer-facing, functional changes. Note that this does not include changes only to help content. (see [Modifying change log](https://github.com/Azure/azure-cli/tree/master/doc/authoring_command_modules#modify-change-log)).
+- [ ] The PR title and description has followed the guideline in [Submitting Pull Requests](https://github.com/Azure/azure-cli/tree/dev/doc/authoring_command_modules#submitting-pull-requests).
 
 - [ ] I adhere to the [Command Guidelines](https://github.com/Azure/azure-cli/blob/dev/doc/command_guidelines.md).
+
+- [ ] I adhere to the [Error Handling Guidelines](https://github.com/Azure/azure-cli/blob/dev/doc/error_handling_guidelines.md).

.gitignore

@@ -112,5 +112,7 @@ pip.log
 # Tox
 .tox/
 
-az_command_coverage.txt
+# exe
+*.exe
 
+az_command_coverage.txt

.snapcraft.yaml

@@ -28,7 +28,7 @@ parts:
       - libssl1.0.0
     requirements: requirements.txt
     install: |
-      python_packages="src/azure-cli-core src/azure-cli-nspkg src/azure-cli-command_modules-nspkg src/command_modules/azure-cli*"
+      python_packages="src/azure-cli-core src/command_modules/azure-cli*"
       export PYTHONUSERBASE=$SNAPCRAFT_PART_INSTALL
       export PYTHONHOME=$SNAPCRAFT_PART_INSTALL/usr
       echo $SNAPCRAFT_PART_INSTALL/usr/bin/python3

.vscode/extensions.json

@@ -0,0 +1,5 @@
+{
+    "recommendations": [
+        "ms-python.python"
+    ]
+}