Avoid generating broken code when the object type is in a union
#231
+2,794
−1,093
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
TimothyGu
reviewed
Jan 3, 2021
| undefined overloadsBooleanOrNumeric(boolean arg1); | ||
| undefined overloadsBooleanOrNumeric(long arg1); | ||
|
|
||
| // ## Avoid regressions: |
There was a problem hiding this comment.
I thought the present bug has to do with union types? Is overloading affected by the bug as well?
I'd also prefer a more surgical test suite. The snapshot generated from this file is really huge and not reviewable.
There was a problem hiding this comment.
Is overloading affected by the bug as well?
The current version isn’t, because overloads had the bug fixed at some point.
MattiasBuelens
added a commit
to MattiasBuelens/webidl2js
that referenced
this pull request
Sep 28, 2025
Fixes the crash reported in jsdom#231.
MattiasBuelens
added a commit
to MattiasBuelens/webidl2js
that referenced
this pull request
Sep 28, 2025
This also fixes the crash reported in jsdom#231.
MattiasBuelens
added a commit
to MattiasBuelens/webidl2js
that referenced
this pull request
Sep 28, 2025
This also fixes the crash reported in jsdom#231.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WebIDL2JS currently crashes when the
objecttype is in a union, this fixes that.Depends on:
NoUselessIfElse.webidl#233