Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Double Decompression When Using GCloud GZIP #1457

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Fix Double Decompression When Using GCloud GZIP #1457

wants to merge 4 commits into from

Conversation

thuibr
Copy link

@thuibr thuibr commented Oct 2, 2024

This closes #1456.

@thuibr thuibr changed the title prevent automatic decompression by google client Fix Double Decompression When Using GCloud GZIP Oct 2, 2024
@thuibr
Copy link
Author

thuibr commented Oct 2, 2024

@jschneier what are your thoughts on this change as opposed to using raw_download=True in the client per https://stackoverflow.com/questions/67744979/how-to-prevent-gcs-from-automatically-decompressing-objects-when-using-python-sd ?

@thuibr
Copy link
Author

thuibr commented Oct 3, 2024

@jschneier I added a test. How do I run the tests in CI?

@thuibr
Copy link
Author

thuibr commented Oct 7, 2024

@jschneier can you merge this?

@thuibr
Copy link
Author

thuibr commented Oct 22, 2024

@jschneier can you look at this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix GCloud GZIP
1 participant
@thuibr