Raise not exists error when attempting to get size for unexisting S3 file #1309
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of now, attempting to get the file size from
S3Storage
always raises abotocore.ClientError
, which is vague and may not fall under existing file-management related error handling.Since may other methods in S3 storage already implement this kind of logic I have put the same in the
S3Storage.size
method. Now if the S3 error is a "not found" a more explanatoryFileNotFoundError
is raised instead.