Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add instructions for using django-storages with Scaleway Object storage #1259

Closed
wants to merge 4 commits into from

Conversation

mrchrisadams
Copy link

@mrchrisadams mrchrisadams commented Jul 11, 2023

hi there!

Thank you for creating Django Storage - I figured out how to use it with Scaleway Object storage this week for a project, which is broadly compatible with AWS S3 storage, and I wanted to share this back.

I'm a little rusty with my restructured text, so I've made this draft PR, and once I figure out how to format the code example in the docs, I'll remove the draft status, ready for review.

I think I've updated it now.

Add instructions for using with Scaleway Object Storage
Reformat the code sample - it's not GH markdown
@mrchrisadams mrchrisadams changed the title DRAFT: Create instructions for using with Scaleway Add instructions for using django-storages with Scaleway Object storage Jul 11, 2023

- Set ``AWS_BUCKET_NAME`` to the Bucket you want write to (such as ``my-chosen-bucket``)
- Set ``AWS_S3_REGION_NAME`` to your Scaleway region (such as ``nl-ams`` or ``fr-par``)
- Set ``AWS_S3_ENDPOINT_URL`` to the value of ``https://{AWS_BUCKET_NAME}.s3.${AWS_S3_REGION_NAME}.scw.cloud``
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The bucket name should not be included into the endpoint.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Laurent, much appreciated 👍

docs/backends/scaleway.rst Outdated Show resolved Hide resolved
@mrchrisadams
Copy link
Author

I've made that change now @lvjp - this look ok now?

@jschneier
Copy link
Owner

The docs have been restructured a bit so that the S3 compatible backends are in their own section. Now that that's inplace I'd be happy to take this if you want to rebase to fit it into that structure.

Comment on lines +20 to +22
If would be written to the following address:

https://s3.nl-ams.scw.cloud/my-chosen-bucket/my_chosen_file.txt
Copy link

@lvjp lvjp Apr 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
If would be written to the following address:
https://s3.nl-ams.scw.cloud/my-chosen-bucket/my_chosen_file.txt
If would be written to the following addresses:
https://s3.nl-ams.scw.cloud/my-chosen-bucket/my_chosen_file.txt
https://my-chosen-bucket.s3.nl-ams.scw.cloud/my_chosen_file.txt

@jschneier
Copy link
Owner

Superseded by #1419

@jschneier jschneier closed this Jul 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants