Skip to content

Adding top margin to example header #481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 14, 2025
Merged

Adding top margin to example header #481

merged 1 commit into from
Apr 14, 2025

Conversation

aldimar-junior
Copy link
Contributor

Relates to grunt-jquery-content issue #95

mgol
mgol approved these changes Apr 12, 2025
View reviewed changes
Copy link
Member

@mgol mgol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I'd like someone else to have a look as well before merging.

@mgol mgol requested a review from timmywil April 12, 2025 11:33
@mgol mgol merged commit 6e0a3fa into jquery:main Apr 14, 2025
5 checks passed
@mgol
Copy link
Member

mgol commented Apr 14, 2025

Timmy approved during the jQuery Core team meeting so I've merged this. Thanks!

mgol pushed a commit to jquery/grunt-jquery-content that referenced this pull request Apr 14, 2025
@aldimar-junior
API Sites: Separate consecutive examples more clearly
00ee37d 
If there's more than one example append an `<h3>` tag with the number of
the example, e.g. "Example 1".

Closes gh-95
Ref jquery/api.jquery.com#1157
Ref jquery/jquery-wp-content#481
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgol mgol mgol approved these changes

@timmywil timmywil Awaiting requested review from timmywil

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aldimar-junior @mgol