Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api.jqueryui.com: Prepare for jQuery UI 1.14 #460

Merged
merged 1 commit into from
Jul 19, 2024
Merged

Conversation

mgol
Copy link
Member

@mgol mgol commented Jul 10, 2024

Also, update jQuery UI used on releases.jquery.com from 1.13.2 to 1.13.3.

Also, update jQuery UI used on releases.jquery.com from 1.13.2 to 1.13.3.
@mgol mgol requested review from Krinkle and timmywil July 10, 2024 23:12
@mgol
Copy link
Member Author

mgol commented Jul 10, 2024

@Krinkle Also, could you edit the jQuery UI Wiki to update the instructions for the new infra? I think only the section at https://github.com/jquery/jquery-ui/wiki/Release-process#apijqueryuicom is affected; it mentions builder.pp & the puppet-stage branch.

@Krinkle
Copy link
Member

Krinkle commented Jul 10, 2024

@mgol I've documented how it works at https://github.com/jquery/infrastructure-puppet/blob/staging/doc/wordpress.md.

Please have a look (especially the "Control flow" section), perhaps that helps with what's implicitly needed for a new subsite? Let me know, I can give it a go as well, happy to review/double check either way.

@mgol
Copy link
Member Author

mgol commented Jul 12, 2024

@Krinkle This may be a stretch with the current activity, but what if I wanted to start working on a site for the next UI release (here: 1.14) while not tagging it as the default version? I could create an entry for api_jqueryui_com_1_14 and after 1.14.0 final rename the existing api_jqueryui_com to api_jqueryui_com_1_13 followed by the renaming of api_jqueryui_com_1_14 to api_jqueryui_com; would that work?

@Krinkle
Copy link
Member

Krinkle commented Jul 13, 2024

@mgol I believe so, yes. I don't think we have any coupling to, or awareness of, what the subsites represent, at the infrastructure level. So a subsite being "semver newer" than the main site, should not pose an problem.

We shall find out on staging, but from reviewing the code just now, I don't see anything stand out that would go wrong.

I do note that if we do this, the 1.14 subsite would become 404 Not Found, although we can fix that by adding a 302 redirect for it under the api_jqueryui_com block in infrastructure-puppet:/hierdata/common.yaml (I suggest 302, since it may potentially become a directory again in the future.)

@mgol
Copy link
Member Author

mgol commented Jul 19, 2024

OK, I guess I'll just switch the docs to 1.14 at this point to reduce the churn a bit. API changes are minor so the docs should work just as fine for 1.13 users.

@mgol mgol merged commit c475c28 into jquery:main Jul 19, 2024
5 checks passed
@mgol mgol deleted the ui-1-14 branch July 19, 2024 16:12
@mgol
Copy link
Member Author

mgol commented Jul 19, 2024

@mgol
Copy link
Member Author

mgol commented Jul 19, 2024

A counterpart infra PR: jquery/infrastructure-puppet#56

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants