Core: Fill in & warn against jQuery.proxy #530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgol
force-pushed
the
proxy
branch
3 times, most recently
from
ddfd99f
to
1aba980
Compare
mgol
commented
Sep 30, 2024
Comment on lines
+27
to
+38
| function isFunction( obj ) { | ||
|
|
||
| // Support: Chrome <=57, Firefox <=52 | ||
| // In some browsers, typeof returns "function" for HTML <object> elements | ||
| // (i.e., `typeof document.createElement( "object" ) === "function"`). | ||
| // We don't want to classify *any* DOM node as a function. | ||
| // Support: QtWeb <=3.8.5, WebKit <=534.34, wkhtmltopdf tool <=0.12.5 | ||
| // Plus for old WebKit, typeof returns "function" for HTML collections | ||
| // (e.g., `typeof document.getElementsByTagName("div") === "function"`). (gh-4756) | ||
| return typeof obj === "function" && typeof obj.nodeType !== "number" && | ||
| typeof obj.item !== "function"; | ||
| } |
There was a problem hiding this comment.
I'll remove this wrapper in Migrate 4.0 as a regular typeof will suffice then.
timmywil
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes gh-460