P:builder: Don't run npm update or npm prune, run npm ci
#78
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes: 1. Use `npm ci` in favor of `npm install` 2. Don't run `npm update` or `npm prune`. The latter is unnecessary, and the former is breaking the build when new incompatible dependencies come out. Also, just blindly updating everything to the latest version makes us more vulnerable to supply chain attacks in our dependencies.
timmywil
approved these changes
Aug 12, 2025
Krinkle
reviewed
Aug 12, 2025
|
This will resolve #38. |
Co-authored-by: Timo Tijhof <[email protected]>
Krinkle
approved these changes
Aug 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
npm ciin favor ofnpm installwhenever a lockfile is present.npm updateornpm prune. The latter is unnecessary, and the former is breaking the build when new incompatible dependencies come out. Also, just blindly updating everything to the latest version makes us more vulnerable to supply chain attacks in our dependencies.Fixes gh-38