Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CSP header refinements #61

Merged
merged 4 commits into from
Sep 10, 2024
Merged

CSP header refinements #61

merged 4 commits into from
Sep 10, 2024

Conversation

timmywil
Copy link
Member

@timmywil timmywil commented Sep 5, 2024 •
edited by Krinkle
Loading

  • add Reporting-Endpoints header to be used by report-to (report-uri can use URLs directly)
  • specify both report-to and report-uri
  • update CSP header for gruntjs.com

Ref #54.

mgol
mgol reviewed Sep 5, 2024
View reviewed changes
Copy link
Member

@mgol mgol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Firefox doesn’t support report-to yet, only report-uri. Until it gains support, shouldn’t we specify both or even only report-uri?

@timmywil
Copy link
Member Author

timmywil commented Sep 5, 2024

Let's use both since report-uri is deprecated.

@Krinkle Krinkle mentioned this pull request Sep 5, 2024
Closed
@timmywil timmywil requested a review from mgol September 5, 2024 20:06
@timmywil timmywil merged commit 1f32292 into jquery:staging Sep 10, 2024
2 checks passed
@timmywil timmywil deleted the csp branch September 10, 2024 12:39
@Krinkle Krinkle mentioned this pull request Sep 11, 2024
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Krinkle Krinkle Krinkle approved these changes

@mgol mgol mgol approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@timmywil @Krinkle @mgol