Allow building with wineg++ #11
Conversation
Might help solve jpsdr#10.
|
Hello. |
|
No problem at all @jpsdr. I didn't open PR with any expectation of merger. It just helps users see what patches exist if they search Google, that's all. :-) |
|
@ctrlcctrlv You can do better and wrap compiler-specific code into preprocessor's directive, so it will be ignored for visual studio. That way it definitely will not harm the maintainer's experience with VS. You still have to provide another way (meson, cmake or make) to compile nnedi3 plugin with your additions (setting your directive with -D to enable it). |
|
@DJATOM I have no way to test on VS+MSVC, sorry, which is why I didn't already do that. |
|
Hmm. I guess the macro is |
| #ifndef _MSC_VER | ||
| #define _aligned_malloc(size, alignment) aligned_alloc(size, alignment) | ||
| // Note: This is safe on Unix. see `man 3 aligned_alloc` | ||
| #define _aligned_free(m) free(m) |
There was a problem hiding this comment.
@jpsdr You might be right about this on Windows but using free on aligned memory is fine on Unix.
|
OK @DJATOM I did my best even w/o VisualStudio to fix this PR. |
3 participants
Might help solve #10.