Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PECO-1707] Move tests to the folders of corresponding projects #2

Open
wants to merge 3 commits into
base: jprakash-db/PECO-1706
Choose a base branch
from

Conversation

shivam2680
Copy link
Collaborator

test scripts are moved to respective project directories. Pytest config for the tests are also added.

Copy link
Collaborator

@gopalldb gopalldb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason why you are merging into Jothi's fork instead of main branch?

@kravets-levko
Copy link
Collaborator

Any reason why you are merging into Jothi's fork instead of main branch?

At first I didn't realize that you created two forks 🙂 But if that works for you - why not.

We cannot merge directly into Databricks fork because we need it to be stable. This feature is big and the code will not be usable until we're fully done. Therefore we had to work either on a dedicated feature branch, or on the fork (like in this case).

Why targeting jprakash-db/PECO-1706 instead of main? That's generally a good practice when doing chained PRs. This allows to see only relevant changes in diff. Once previous PR is merged - GitHub automatically updates the chained PR to target main branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants