Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Border layout sticky example update #4485

Merged
merged 2 commits into from
Dec 12, 2024
Merged

Border layout sticky example update #4485

merged 2 commits into from
Dec 12, 2024

Conversation

Fercas123
Copy link
Contributor

No description provided.

@vercel Vercel
Copy link

vercel bot commented Dec 10, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
saltdesignsystem ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 12, 2024 3:25pm

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Dec 10, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 298feb7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Fercas123 Fercas123 requested a review from origami-z December 10, 2024 13:28
@Fercas123 Fercas123 force-pushed the sticky-border-example-update branch from 77d198c to 0bef1f4 Compare December 11, 2024 11:14
@Fercas123 Fercas123 linked an issue Dec 11, 2024 that may be closed by this pull request
Border layout sticky example is misleading #4432
Closed
10 tasks
amritadesmet
amritadesmet previously approved these changes Dec 11, 2024
View reviewed changes
@Fercas123 Fercas123 requested a review from origami-z December 11, 2024 11:56
origami-z
origami-z previously approved these changes Dec 12, 2024
View reviewed changes
@Fercas123 Fercas123 force-pushed the sticky-border-example-update branch from 0bef1f4 to 5a67d29 Compare December 12, 2024 14:02
@Fercas123 Fercas123 dismissed stale reviews from origami-z and amritadesmet via b861a49 December 12, 2024 14:54
@Fercas123 Fercas123 force-pushed the sticky-border-example-update branch from b861a49 to 298feb7 Compare December 12, 2024 15:19
@joshwooding joshwooding added the chromatic Run chromatic on the current PR. Will be removed by the CI once submitted. label Dec 12, 2024
@github-actions github-actions bot removed the chromatic Run chromatic on the current PR. Will be removed by the CI once submitted. label Dec 12, 2024
@joshwooding joshwooding merged commit d659b58 into main Dec 12, 2024
15 checks passed
@joshwooding joshwooding deleted the sticky-border-example-update branch December 12, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amritadesmet amritadesmet amritadesmet approved these changes

@joshwooding joshwooding joshwooding approved these changes

@origami-z origami-z Awaiting requested review from origami-z

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Border layout sticky example is misleading
4 participants
@Fercas123 @origami-z @joshwooding @amritadesmet