Update Yarn to v4.5.3

jpmorganchase · joshwooding · Dec 10, 2024 · Dec 10, 2024 · Dec 10, 2024 · 490e46b7a11eac3ccc9c14f35c69591eb6506c17
commit 490e46b7a11eac3ccc9c14f35c69591eb6506c17
diff --git a/.yarn/releases/yarn-4.5.0.cjs b/.yarn/releases/yarn-4.5.0.cjs
diff --git a/.yarn/releases/yarn-4.5.3.cjs b/.yarn/releases/yarn-4.5.3.cjs
diff --git a/.yarnrc.yml b/.yarnrc.yml
@@ -4,4 +4,4 @@ enableGlobalCache: false
 
 nodeLinker: node-modules
 
-yarnPath: .yarn/releases/yarn-4.5.0.cjs
+yarnPath: .yarn/releases/yarn-4.5.3.cjs
diff --git a/package.json b/package.json
@@ -127,7 +127,7 @@
       "last 1 safari version"
     ]
   },
-  "packageManager": "[email protected].0",
+  "packageManager": "[email protected].3",
   "msw": {
     "workerDirectory": "docs/public"
   },

diff --git a/cypress/support/AnnouncementListener.tsx b/cypress/support/AnnouncementListener.tsx
  const obs = useRef(new MutationObserver(handleAnnouncement));

  useEffect(() => {
    document.querySelectorAll(positiveLookUp.join(",")).forEach((node) => {
      if (!node.matches(negativeLookUp.join(","))) {
        obs.current.observe(node, {
          attributes: true,
          subtree: true,
          childList: true,
          characterData: true,
        });
      }
    });
  }, []);

  useEffect(() => {
diff --git a/cypress/tests/checkAccessibility.tsx b/cypress/tests/checkAccessibility.tsx
  stories: StoriesWithPartialProps<ReactRenderer, unknown>,
 ) {
  describe("Axe Testing", () => {
    Object.entries(stories).forEach(([name, StoryComponent]) => {
      const Component = StoryComponent as StoryFn<unknown>;

      const disabledRules: string[] =
        Component.parameters?.axe?.disabledRules ?? [];
      const shouldSkip: boolean = Component.parameters?.axe?.skip;

      const testFunction = shouldSkip ? it.skip : it;

      testFunction(`Story "${name}", should not have an axe violations`, () => {
        cy.mount(<Component />);

        const rules = disabledRules.reduce(
          (acc, rule) => {
            acc[rule] = { enabled: false };
            return acc;
          },
          {} as Required<Options>["rules"],
        );

        cy.checkAxeComponent({ rules }, true);
      });
    });
  });
 }
diff --git a/tooling/css-variable-docgen-plugin/src/index.ts b/tooling/css-variable-docgen-plugin/src/index.ts
        const privateVariableMap: Record<string, PrivateVariable> = {};
        const identifierMap: Record<string, CSSVariable> = {};

        cssFiles.forEach(({ path, contents }) => {
          const comments: Record<number, string> = {};

          const ast = parse(contents, {
            positions: true,
            parseValue: true,
            parseRulePrelude: true,
            parseCustomProperty: true,
            parseAtrulePrelude: true,
            onComment: (value, location) => {
              comments[location.end.line] = value.trim();
            },
          });

          walk(ast, {
            visit: "Selector",
            enter(node) {
              if (
                this.selector?.loc?.start.line &&
                comments[this.selector.loc.start.line - 1]
              ) {
                const name = generate(node);
                if (
                  !comments[this.selector.loc.start.line - 1].includes(
                    "@ignore",
                  )
                ) {
                  classNames[name] = {
                    name,
                    description: comments[this.selector.loc.start.line - 1],
                  };
                }
              }
            },
          });

          walk(ast, {
            visit: "Declaration",
            enter(node) {
              if (node.type === "Declaration") {
                if (node.property.startsWith("--")) {
                  try {
                    privateVariableMap[node.property] = {
                      name: node.property,
                      value: generate(
                        findLast(node.value, (node) =>
                          valueTypes.includes(node.type),
                        ) ?? node.value,
                      ),
                    };
                  } catch (e) {
                    console.warn(
                      e,
                      `Encountered issue parsing CSS variable declaration "${node.property}" in "${path}"`,
                    );
                  }
                }
              }
            },
          });

          walk(ast, {
            visit: "Identifier",
            enter(node) {
              const name = node.name;
              if (name.startsWith("--")) {
                try {
                  identifierMap[name] = {
                    name,
                    property: this.declaration?.property,
                    fallbackValue: this.declaration
                      ? generate(
                          findLast(this.declaration, (node) =>
                            valueTypes.includes(node.type),
                          ),
                        )
                      : undefined,
                  };
                } catch (e) {
                  console.warn(
                    `Encountered issue parsing CSS variable "${name}" in "${path}"`,
                  );
                }
              }
            },
          });
        });

        const resolveProperty = (
          identifierMap: Record<string, CSSVariable>,
          }
        };

        Object.keys(identifierMap).forEach((key) => {
          const identifier = identifierMap[key];
          identifierMap[key].property = resolveProperty(
            identifierMap,
            identifier.property,
          );
          identifierMap[key].fallbackValue = resolveValue(
            identifier.fallbackValue,
          );
        });

        const transformer = <T extends ts.Node>(
          context: ts.TransformationContext,
diff --git a/tooling/css-variable-docgen-components/src/utils.ts b/tooling/css-variable-docgen-components/src/utils.ts
  if (isValidDocgenSection(section)) {
    const characteristicFoundationTokenMap: Record<string, string[]> = {};

    Object.keys(section).forEach((token) => {
      if (token.startsWith("--salt-")) {
        const characteristicName = token.replace("--salt-", "").split("-")[0];
        if (
          characteristicName.length &&
          SALT_CHARACTERISTICS.includes(characteristicName)
        ) {
          if (!characteristicFoundationTokenMap[characteristicName]) {
            characteristicFoundationTokenMap[characteristicName] = [token];
          } else if (
            !characteristicFoundationTokenMap[characteristicName]?.includes(
              token,
            )
          ) {
            characteristicFoundationTokenMap[characteristicName].push(token);
          }
        }
      }
    });

    return characteristicFoundationTokenMap;
  }
diff --git a/docs/components/QAContainer.tsx b/docs/components/QAContainer.tsx
    }}
  >
    {Children.map(children, (child, i) => (
      <div className="background-item-wrapper" key={i}>
        {child}
      </div>
    ))}
      {transposeDensity ? (
        <>
          {Children.map(children, (child, i) => (
            <DensityBlock key={i} mode="light">
              {child}
            </DensityBlock>
          ))}
          {Children.map(children, (child, i) => (
            <DensityBlock key={i} mode="dark">
              {child}
            </DensityBlock>
          ))}
diff --git a/packages/ag-grid-theme/src/examples/CustomFilter.tsx b/packages/ag-grid-theme/src/examples/CustomFilter.tsx
 import dataGridExampleData from "../dependencies/dataGridExampleData";
 import { useAgGridHelpers } from "../dependencies/useAgGridHelpers";

 let savedFilterModel: any = null;

 const CustomFilter = (props: AgGridReactProps) => {
  const [hasSavedState, setHasSavedState] = useState(true);
diff --git a/packages/ag-grid-theme/stories/ag-grid-theme.qa.stories.tsx b/packages/ag-grid-theme/stories/ag-grid-theme.qa.stories.tsx
  const headerCells = await canvas.findAllByText("Capital");

  for (const cell of headerCells) {
    const gridRoot: HTMLElement = cell.closest(".ag-root-wrapper")!;

    cell.closest<HTMLElement>(".ag-header-cell")?.focus();
Original file line number	Diff line number	Diff line change
		@@ -4,4 +4,4 @@ enableGlobalCache: false

		nodeLinker: node-modules

		yarnPath: .yarn/releases/yarn-4.5.0.cjs
		yarnPath: .yarn/releases/yarn-4.5.3.cjs
	const obs = useRef(new MutationObserver(handleAnnouncement));

	useEffect(() => {
	document.querySelectorAll(positiveLookUp.join(",")).forEach((node) => {
	if (!node.matches(negativeLookUp.join(","))) {
	obs.current.observe(node, {
	attributes: true,
	subtree: true,
	childList: true,
	characterData: true,
	});
	}
	});
Check warning on line 50 in cypress/support/AnnouncementListener.tsx GitHub Actions / lint lint/complexity/noForEach `Prefer for...of instead of forEach.`
	}, []);

	useEffect(() => {
	stories: StoriesWithPartialProps<ReactRenderer, unknown>,
	) {
	describe("Axe Testing", () => {
	Object.entries(stories).forEach(([name, StoryComponent]) => {
	const Component = StoryComponent as StoryFn<unknown>;

	const disabledRules: string[] =
	Component.parameters?.axe?.disabledRules ?? [];
	const shouldSkip: boolean = Component.parameters?.axe?.skip;

	const testFunction = shouldSkip ? it.skip : it;

	testFunction(`Story "${name}", should not have an axe violations`, () => {
	cy.mount(<Component />);

	const rules = disabledRules.reduce(
	(acc, rule) => {
	acc[rule] = { enabled: false };
	return acc;
	},
	{} as Required<Options>["rules"],
	);

	cy.checkAxeComponent({ rules }, true);
	});
	});
Check warning on line 31 in cypress/tests/checkAccessibility.tsx GitHub Actions / lint lint/complexity/noForEach `Prefer for...of instead of forEach.`
	});
	}
	const privateVariableMap: Record<string, PrivateVariable> = {};
	const identifierMap: Record<string, CSSVariable> = {};

	cssFiles.forEach(({ path, contents }) => {
	const comments: Record<number, string> = {};

	const ast = parse(contents, {
	positions: true,
	parseValue: true,
	parseRulePrelude: true,
	parseCustomProperty: true,
	parseAtrulePrelude: true,
	onComment: (value, location) => {
	comments[location.end.line] = value.trim();
	},
	});

	walk(ast, {
	visit: "Selector",
	enter(node) {
	if (
	this.selector?.loc?.start.line &&
	comments[this.selector.loc.start.line - 1]
	) {
	const name = generate(node);
	if (
	!comments[this.selector.loc.start.line - 1].includes(
	"@ignore",
	)
	) {
	classNames[name] = {
	name,
	description: comments[this.selector.loc.start.line - 1],
	};
	}
	}
	},
	});

	walk(ast, {
	visit: "Declaration",
	enter(node) {
	if (node.type === "Declaration") {
	if (node.property.startsWith("--")) {
	try {
	privateVariableMap[node.property] = {
	name: node.property,
	value: generate(
	findLast(node.value, (node) =>
	valueTypes.includes(node.type),
	) ?? node.value,
	),
	};
	} catch (e) {
	console.warn(
	e,
	`Encountered issue parsing CSS variable declaration "${node.property}" in "${path}"`,
	);
	}
	}
	}
	},
	});

	walk(ast, {
	visit: "Identifier",
	enter(node) {
	const name = node.name;
	if (name.startsWith("--")) {
	try {
	identifierMap[name] = {
	name,
	property: this.declaration?.property,
	fallbackValue: this.declaration
	? generate(
	findLast(this.declaration, (node) =>
	valueTypes.includes(node.type),
	),
	)
	: undefined,
	};
	} catch (e) {
	console.warn(
	`Encountered issue parsing CSS variable "${name}" in "${path}"`,
	);
	}
	}
	},
	});
	});
Check warning on line 289 in tooling/css-variable-docgen-plugin/src/index.ts GitHub Actions / lint lint/complexity/noForEach `Prefer for...of instead of forEach.`

	const resolveProperty = (
	identifierMap: Record<string, CSSVariable>,
	}
	};

	Object.keys(identifierMap).forEach((key) => {
	const identifier = identifierMap[key];
	identifierMap[key].property = resolveProperty(
	identifierMap,
	identifier.property,
	);
	identifierMap[key].fallbackValue = resolveValue(
	identifier.fallbackValue,
	);
	});
Check warning on line 331 in tooling/css-variable-docgen-plugin/src/index.ts GitHub Actions / lint lint/complexity/noForEach `Prefer for...of instead of forEach.`

	const transformer = <T extends ts.Node>(
	context: ts.TransformationContext,
	if (isValidDocgenSection(section)) {
	const characteristicFoundationTokenMap: Record<string, string[]> = {};

	Object.keys(section).forEach((token) => {
	if (token.startsWith("--salt-")) {
	const characteristicName = token.replace("--salt-", "").split("-")[0];
	if (
	characteristicName.length &&
	SALT_CHARACTERISTICS.includes(characteristicName)
	) {
	if (!characteristicFoundationTokenMap[characteristicName]) {
	characteristicFoundationTokenMap[characteristicName] = [token];
	} else if (
	!characteristicFoundationTokenMap[characteristicName]?.includes(
	token,
	)
	) {
	characteristicFoundationTokenMap[characteristicName].push(token);
	}
	}
	}
	});
Check warning on line 60 in tooling/css-variable-docgen-components/src/utils.ts GitHub Actions / lint lint/complexity/noForEach `Prefer for...of instead of forEach.`

	return characteristicFoundationTokenMap;
	}
	}}
	>
	{Children.map(children, (child, i) => (
	<div className="background-item-wrapper" key={i}>
Check warning on line 47 in docs/components/QAContainer.tsx GitHub Actions / lint lint/suspicious/noArrayIndexKey `Avoid using the index of an array as key property in an element.`
	{child}
	</div>
	))}
	{transposeDensity ? (
	<>
	{Children.map(children, (child, i) => (
	<DensityBlock key={i} mode="light">
Check warning on line 113 in docs/components/QAContainer.tsx GitHub Actions / lint lint/suspicious/noArrayIndexKey `Avoid using the index of an array as key property in an element.`
	{child}
	</DensityBlock>
	))}
	{Children.map(children, (child, i) => (
	<DensityBlock key={i} mode="dark">
Check warning on line 118 in docs/components/QAContainer.tsx GitHub Actions / lint lint/suspicious/noArrayIndexKey `Avoid using the index of an array as key property in an element.`
	{child}
	</DensityBlock>
	))}
	import dataGridExampleData from "../dependencies/dataGridExampleData";
	import { useAgGridHelpers } from "../dependencies/useAgGridHelpers";

	let savedFilterModel: any = null;
Check warning on line 8 in packages/ag-grid-theme/src/examples/CustomFilter.tsx GitHub Actions / lint lint/suspicious/noExplicitAny `Unexpected any. Specify a different type.`

	const CustomFilter = (props: AgGridReactProps) => {
	const [hasSavedState, setHasSavedState] = useState(true);
	const headerCells = await canvas.findAllByText("Capital");

	for (const cell of headerCells) {
	const gridRoot: HTMLElement = cell.closest(".ag-root-wrapper")!;
Check warning on line 63 in packages/ag-grid-theme/stories/ag-grid-theme.qa.stories.tsx GitHub Actions / lint lint/style/noNonNullAssertion `Forbidden non-null assertion.`

	cell.closest<HTMLElement>(".ag-header-cell")?.focus();