-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scope floating ui portal #4385
Scope floating ui portal #4385
Conversation
🦋 Changeset detectedLatest commit: 35565e6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@origami-z Is there anything blocking this PR? |
no, i wanted to see chromatic or snapshot test |
eb95820
to
35565e6
Compare
@origami-z Are you happy for this to be merged in? |
/release-pr |
🫰✨ Thanks @origami-z! Your snapshots have been published to npm. Test the snapshots by updating your yarn add @salt-ds/[email protected] yarn add @salt-ds/[email protected] yarn add @salt-ds/[email protected] yarn add @salt-ds/[email protected] |
tested with |
@ImmanuelBaskaran do you think this will impact desktop? |
This does not affect desktop, we provide our own floating portal component. |
This should solve the problem where users using mixed density and portal launch mess up the whole UI, as well as sometimes multiple version of Salt core packages are used in portal and root attributes are removed