Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scope floating ui portal #4385

Merged
merged 2 commits into from
Dec 12, 2024
Merged

Scope floating ui portal #4385

merged 2 commits into from
Dec 12, 2024

Conversation

origami-z
Copy link
Contributor

@origami-z origami-z commented Nov 7, 2024

This should solve the problem where users using mixed density and portal launch mess up the whole UI, as well as sometimes multiple version of Salt core packages are used in portal and root attributes are removed

Copy link

changeset-bot bot commented Nov 7, 2024

🦋 Changeset detected

Latest commit: 35565e6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@salt-ds/core Patch
@salt-ds/countries Patch
@salt-ds/data-grid Patch
@salt-ds/lab Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Nov 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
saltdesignsystem ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 12, 2024 10:02am

@origami-z origami-z added the chromatic Run chromatic on the current PR. Will be removed by the CI once submitted. label Nov 7, 2024
@github-actions github-actions bot removed the chromatic Run chromatic on the current PR. Will be removed by the CI once submitted. label Nov 7, 2024
@joshwooding
Copy link
Contributor

@origami-z Is there anything blocking this PR?

@origami-z
Copy link
Contributor Author

@origami-z Is there anything blocking this PR?

no, i wanted to see chromatic or snapshot test

@joshwooding joshwooding added the chromatic Run chromatic on the current PR. Will be removed by the CI once submitted. label Dec 12, 2024
@github-actions github-actions bot removed the chromatic Run chromatic on the current PR. Will be removed by the CI once submitted. label Dec 12, 2024
@joshwooding joshwooding marked this pull request as ready for review December 12, 2024 12:30
@joshwooding
Copy link
Contributor

@origami-z Are you happy for this to be merged in?

@origami-z
Copy link
Contributor Author

/release-pr

Copy link
Contributor

🫰✨ Thanks @origami-z! Your snapshots have been published to npm.

Test the snapshots by updating your package.json with the newly published versions:

yarn add @salt-ds/[email protected]
yarn add @salt-ds/[email protected]
yarn add @salt-ds/[email protected]
yarn add @salt-ds/[email protected]

@origami-z
Copy link
Contributor Author

@origami-z Are you happy for this to be merged in?

tested with 0.0.0-snapshot-20241212132702, working locally

@origami-z
Copy link
Contributor Author

@ImmanuelBaskaran do you think this will impact desktop?

@ImmanuelBaskaran
Copy link
Contributor

This does not affect desktop, we provide our own floating portal component.

@joshwooding joshwooding merged commit dedbade into main Dec 12, 2024
14 of 15 checks passed
@joshwooding joshwooding deleted the floating-ui-scoping branch December 12, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants