Date picker review2 #4291
Merged
Date picker review2 #4291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: bdecb22 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This was referenced Oct 14, 2024
Closed
origami-z
reviewed
Oct 21, 2024
mark-tate
force-pushed
the
date-picker-review2
branch
from
e17d8a7 to
4b99c7f
Compare
mark-tate
force-pushed
the
date-picker-review2
branch
from
4b99c7f to
47b4074
Compare
|
/release-pr |
|
🫰✨ Thanks @origami-z! Your snapshots have been published to npm. Test the snapshots by updating your yarn add @salt-ds/[email protected]yarn add @salt-ds/[email protected]yarn add @salt-ds/[email protected]yarn add @salt-ds/[email protected]yarn add @salt-ds/[email protected]yarn add @salt-ds/[email protected] |
|
/release-pr |
|
🫰✨ Thanks @origami-z! Your snapshots have been published to npm. Test the snapshots by updating your yarn add @salt-ds/[email protected]yarn add @salt-ds/[email protected]yarn add @salt-ds/[email protected]yarn add @salt-ds/[email protected]yarn add @salt-ds/[email protected]yarn add @salt-ds/[email protected] |
Slowly adding tests on https://stackblitz.com/edit/salt-template-xqddfx?file=App.tsx |
origami-z
reviewed
Nov 5, 2024
origami-z
reviewed
Nov 5, 2024
origami-z
reviewed
Nov 5, 2024
origami-z
reviewed
Nov 5, 2024
origami-z
reviewed
Nov 5, 2024
|
/release-pr |
|
🫰✨ Thanks @origami-z! Your snapshots have been published to npm. Test the snapshots by updating your yarn add @salt-ds/[email protected]yarn add @salt-ds/[email protected]yarn add @salt-ds/[email protected]yarn add @salt-ds/[email protected]yarn add @salt-ds/[email protected]yarn add @salt-ds/[email protected] |
origami-z
reviewed
Nov 6, 2024
origami-z
reviewed
Nov 6, 2024
origami-z
reviewed
Nov 6, 2024
…er than null - null is used to represent an empty date - use date adapter's `isValid` to determine the state - refactor the selection API to seperate the date change from the details of any error
- storybook support of data adapter via parameters - cypress `mount` now provides a `LocalizationProvider, if a date adapter is defined - cypress commands, `setDateAdapter` and `setDateLocale` to configure date adapter - bug fixes surfaced by adding tests
…rs or fallback to globals
…f parsing - added range custom parsing example to Storybook - added test for range custom parsing
- re-added react types in labs - annotated the CustomDatePickerPanel imports - corrected Ref type in DateInputSingle
mark-tate
force-pushed
the
date-picker-review2
branch
from
b2bab1c to
bdecb22
Compare
origami-z
approved these changes
Nov 27, 2024
Fercas123
approved these changes
Nov 28, 2024
origami-z
added
the
chromatic
github-actions
bot
removed
the
chromatic
Closed
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.