Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #182

Merged
merged 1 commit into from
Nov 6, 2023
Merged

Update README.md #182

merged 1 commit into from
Nov 6, 2023

Conversation

vidartf
Copy link
Contributor

@vidartf vidartf commented Nov 6, 2023

Ensure correct caps spelling. Fixes #180.

Ensure correct caps spelling.
Copy link

github-actions bot commented Nov 6, 2023

Binder Launch a binder notebook on branch jpmorganchase/jupyter-fs/update-configclass-readme

@vidartf vidartf requested a review from timkpaine November 6, 2023 17:19
Copy link

github-actions bot commented Nov 6, 2023

Test Results

  3 files  ±0    5 suites  ±0   1m 11s ⏱️ +29s
15 tests ±0  15 ✔️ ±0  0 💤 ±0  0 ±0 
17 runs  ±0  17 ✔️ ±0  0 💤 ±0  0 ±0 

Results for commit 496c31f. ± Comparison against base commit 135811c.

Copy link

codecov bot commented Nov 6, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (135811c) 37.86% compared to head (496c31f) 37.86%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #182   +/-   ##
=======================================
  Coverage   37.86%   37.86%           
=======================================
  Files          31       31           
  Lines        1965     1965           
  Branches      312      312           
=======================================
  Hits          744      744           
  Misses       1119     1119           
  Partials      102      102           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@timkpaine
Copy link
Collaborator

I'm probably going to support either soon, but lgtm

@timkpaine timkpaine merged commit 0889331 into main Nov 6, 2023
5 checks passed
@timkpaine timkpaine deleted the update-configclass-readme branch November 6, 2023 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix doc: Jupyterfs has to be JupyterFs in config files
2 participants