Skip to content
This repository was archived by the owner on May 26, 2020. It is now read-only.

Provide request to contrib.auth.authenticate in JSONWebTokenSerializer#388

Open
gtnx wants to merge 1 commit intojpadilla:masterfrom
gtnx:issue-387
Open

Provide request to contrib.auth.authenticate in JSONWebTokenSerializer#388
gtnx wants to merge 1 commit intojpadilla:masterfrom
gtnx:issue-387

Conversation

@gtnx
Copy link
Copy Markdown

@gtnx gtnx commented Oct 9, 2017

refs #387

@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 9, 2017

Codecov Report

Merging #388 into master will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #388      +/-   ##
=========================================
+ Coverage   90.67%   90.7%   +0.03%     
=========================================
  Files          14      14              
  Lines         847     850       +3     
  Branches       29      30       +1     
=========================================
+ Hits          768     771       +3     
  Misses         66      66              
  Partials       13      13
Flag Coverage Δ
#codecov 90.7% <100%> (+0.03%) ⬆️
#dj110 87.29% <50%> (-0.2%) ⬇️
#dj111 87.29% <50%> (-0.2%) ⬇️
#dj18 89.64% <50%> (-0.2%) ⬇️
#dj19 89.64% <50%> (-0.2%) ⬇️
#drf31 89.64% <50%> (-0.2%) ⬇️
#drf32 89.64% <50%> (-0.2%) ⬇️
#drf33 89.64% <50%> (-0.2%) ⬇️
#drf34 90.7% <100%> (+0.03%) ⬆️
#drf35 90.35% <100%> (+0.03%) ⬆️
#drf36 90.35% <100%> (+0.03%) ⬆️
#py27 90.7% <100%> (+0.03%) ⬆️
#py33 89.29% <50%> (-0.2%) ⬇️
#py34 89.29% <50%> (-0.2%) ⬇️
Impacted Files Coverage Δ
rest_framework_jwt/serializers.py 82.97% <100%> (+0.56%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a0bd40...8475cef. Read the comment docs.

@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 9, 2017

Codecov Report

Merging #388 into master will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #388      +/-   ##
=========================================
+ Coverage   90.67%   90.7%   +0.03%     
=========================================
  Files          14      14              
  Lines         847     850       +3     
  Branches       29      30       +1     
=========================================
+ Hits          768     771       +3     
  Misses         66      66              
  Partials       13      13
Flag Coverage Δ
#codecov 90.7% <100%> (+0.03%) ⬆️
#dj110 87.29% <50%> (-0.2%) ⬇️
#dj111 87.29% <50%> (-0.2%) ⬇️
#dj18 89.64% <50%> (-0.2%) ⬇️
#dj19 89.64% <50%> (-0.2%) ⬇️
#drf31 89.64% <50%> (-0.2%) ⬇️
#drf32 89.64% <50%> (-0.2%) ⬇️
#drf33 89.64% <50%> (-0.2%) ⬇️
#drf34 90.7% <100%> (+0.03%) ⬆️
#drf35 90.35% <100%> (+0.03%) ⬆️
#drf36 90.35% <100%> (+0.03%) ⬆️
#py27 90.7% <100%> (+0.03%) ⬆️
#py33 89.29% <50%> (-0.2%) ⬇️
#py34 89.29% <50%> (-0.2%) ⬇️
Impacted Files Coverage Δ
rest_framework_jwt/serializers.py 82.97% <100%> (+0.56%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a0bd40...8475cef. Read the comment docs.

@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 9, 2017 •
edited
Loading

Codecov Report

Merging #388 into master will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #388      +/-   ##
=========================================
+ Coverage   90.67%   90.7%   +0.03%     
=========================================
  Files          14      14              
  Lines         847     850       +3     
  Branches       29      30       +1     
=========================================
+ Hits          768     771       +3     
  Misses         66      66              
  Partials       13      13
Flag Coverage Δ
#codecov 90.7% <100%> (+0.03%) ⬆️
#dj110 87.29% <50%> (-0.2%) ⬇️
#dj111 87.29% <50%> (-0.2%) ⬇️
#dj18 89.64% <50%> (-0.2%) ⬇️
#dj19 89.64% <50%> (-0.2%) ⬇️
#drf31 89.64% <50%> (-0.2%) ⬇️
#drf32 89.64% <50%> (-0.2%) ⬇️
#drf33 89.64% <50%> (-0.2%) ⬇️
#drf34 90.7% <100%> (+0.03%) ⬆️
#drf35 90.35% <100%> (+0.03%) ⬆️
#drf36 90.35% <100%> (+0.03%) ⬆️
#py27 90.7% <100%> (+0.03%) ⬆️
#py33 89.29% <50%> (-0.2%) ⬇️
#py34 89.29% <50%> (-0.2%) ⬇️
Impacted Files Coverage Δ
rest_framework_jwt/serializers.py 82.97% <100%> (+0.56%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a0bd40...c3fd1d6. Read the comment docs.

blueyed
blueyed reviewed Oct 9, 2017
View reviewed changes
Comment thread rest_framework_jwt/serializers.py Outdated
from calendar import timegm
from datetime import datetime, timedelta

from django import __version__
Copy link
Copy Markdown
Contributor

@blueyed blueyed Oct 9, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better just import django and then use if django.VERSION >= (1, 11)

@gtnx gtnx force-pushed the issue-387 branch 2 times, most recently from edeedd7 to ef75421 Compare October 9, 2017 20:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@blueyed blueyed blueyed left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@gtnx @blueyed