broke out merge logic and added UnitTests #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moved merge logic to seperate class to enable unit testing
jpabeem
approved these changes
Oct 23, 2018
MergePDF/PdfMerger.cs
Outdated
| } | ||
| catch (Exception) | ||
| { | ||
| throw; |
There was a problem hiding this comment.
There must be a better way to deal with exceptions. This solution does not correspond with the rest of your code quality, perhaps you can think of a way to improve on this?
There was a problem hiding this comment.
you are right! I removed the catch / throw
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Broke out actual merge logic to streamline testing