Add Firmware files with Encoder Keymap for Via#14
Open
Kaiserdragon2 wants to merge 3 commits intojoshajohnson:masterfrom
Open
Add Firmware files with Encoder Keymap for Via#14Kaiserdragon2 wants to merge 3 commits intojoshajohnson:masterfrom
Kaiserdragon2 wants to merge 3 commits intojoshajohnson:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am not sure how to best implement it in to the existing folder structure, so i added a folder hub16_new in the firmware folder.
This adds the ability to change the encoder in via.
Therefore I added a new via config beside the default one from QMK with encoder key mapping.
I also added a via_hub16.json for the VIA configurator to recognize the encoders.