Fix slow push#1392
Merged
christian-schilling merged 1 commit intoSep 24, 2024
Merged
Conversation
To determine which files are part of a filtered subset, regardless of their potentially changed path a trick is used: The filter is applied and then the inverted filter is applied to the result. The implementation of that trick was to simply chain the filter with the inverted one. However this caused flatten() to create a hughe intermediate representation (something like a cartesian product) that then has to be simplified down again by optimize()/simplify(). While that worked, it was very computationally expensive making push extremly slow in some cases. Now instead of chaining apply() is called twice, avoiding the huge intermediate representation and thus expensive optimization. Change: fix-slow-push
LMG
approved these changes
Sep 24, 2024
christian-schilling
deleted the
@changes/master/christian.schilling.de@gmail.com/fix-slow-push
branch
christian-schilling
added a commit
that referenced
this pull request
Oct 11, 2025
To determine which files are part of a filtered subset, regardless of their potentially changed path a trick is used: The filter is applied and then the inverted filter is applied to the result. The implementation of that trick was to simply chain the filter with the inverted one. However this caused flatten() to create a hughe intermediate representation (something like a cartesian product) that then has to be simplified down again by optimize()/simplify(). While that worked, it was very computationally expensive making push extremly slow in some cases. Now instead of chaining apply() is called twice, avoiding the huge intermediate representation and thus expensive optimization. Change: fix-slow-push
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To determine which files are part of a filtered subset, regardless of their potentially changed path a trick is used: The filter is applied and then the inverted filter is applied to the result.
The implementation of that trick was to simply chain the filter with the inverted one. However this caused flatten() to create a hughe intermediate representation (something like a cartesian product) that then has to be simplified down again by optimize()/simplify(). While that worked, it was very computationally expensive making push extremly slow in some cases.
Now instead of chaining apply() is called twice, avoiding the huge intermediate representation and thus expensive optimization.
Change: fix-slow-push