Added Css Background Support. Updated Support for IE. Added CSS filters incase canvas has issues.#4
Open
mintystark wants to merge 3 commits intojosefrichter:masterfrom
Open
Added Css Background Support. Updated Support for IE. Added CSS filters incase canvas has issues.#4mintystark wants to merge 3 commits intojosefrichter:masterfrom
mintystark wants to merge 3 commits intojosefrichter:masterfrom
Conversation
…ork. Added CSS Background Image Support, Added CSS incase Canvas doesn't work. Fixed issues with IE. The original code was not working with IE 9 and 10. It has been tested with IE 9,10,11 FF 31, Chrome 36, Safari 7
Owner
|
hey, thanks! line 21-24 of the original file - why would you remove the ms filters and put there canvas? the problem was that anything below IE9 didn't support canvas, but it did support those filters.. maybe even IE9+ still supports those filters which is actually a better solution than this canvas "hack".. |
Author
|
Actually, IE9 did not work for me until I removed those lines. Same for IE10. Also I don't care about anything under IE9. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.