Add follow_only_path flag to dumb down filewatching to just paths #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Had to do a little special case handling of paths with spaces/carriage returns in them to prevent parsing errors in _sincedb |
|
@michio-nikaido could you please rebase your PR against current master, the creation of the sincedb_identifier is now in its own method so your code and superb comment should go here please https://github.com/jordansissel/ruby-filewatch/blob/master/lib/filewatch/tail.rb#L110 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm putting together a Logstash deployment which involves a number of production servers regularly rsync'ing files to a central log repository. When running Logstash from this central server, it appears that the filewatch code behind the Logstash 'file' input is detecting the updated inode on each rsync and treating the file as new.
The changes here allow a 'follow_only_path' flag to be specified that causes the inode variable to be constructed from the file path rather than the file's inode. This allows the inode variable to remain the same after an rsync updates the file's inode, allowing the @sincedb lookup to file the same entry and continue parsing the file from where it left off