Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.3][cypress] php warning #45030

Open
wants to merge 3 commits into
base: 5.3-dev
Choose a base branch
from
Open

[5.3][cypress] php warning #45030

wants to merge 3 commits into from

Conversation

alikon
Copy link
Contributor

@alikon alikon commented Feb 27, 2025

Pull Request for Issue #45007 .

Summary of Changes

check array key

Testing Instructions

run
npx cypress run --spec '.\tests\System\integration\api\com_users\Users.cy.js'

Actual result BEFORE applying this Pull Request

[24-Feb-2025 19:25:27 UTC] PHP Warning: Undefined array key "password2" in D:\repos\j51\administrator\components\com_users\src\Model\UserModel.php on line 295

Expected result AFTER applying this Pull Request

no more warning

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@alikon alikon marked this pull request as ready for review February 28, 2025 08:40
@muhme
Copy link
Contributor

muhme commented Mar 1, 2025

✅ successful tested with JBT, before applying this PR on 5.2-dev

scripts/create 52
scripts/test 52 system api/com_users/Users.cy.js 

There are two PHP Warnings:

[Sat Mar 01 15:54:09.120420 2025] [php:warn] [pid 23:tid 23] [client 10.0.0.1:58812] PHP Warning:  Undefined array key "password2" in /var/www/html/administrator/components/com_users/src/Model/UserModel.php on line 295
[Sat Mar 01 15:54:09.477295 2025] [php:warn] [pid 23:tid 23] [client 10.0.0.1:58812] PHP Warning:  Undefined array key "password2" in /var/www/html/administrator/components/com_users/src/Model/UserModel.php on line 295

Applying this PR and test again:

scripts/patch 52 joomla-cms-45030
scripts/test 52 system api/com_users/Users.cy.js 

The Cypress test runs now without PHP Warnings successfully 👍

@alikon alikon changed the base branch from 5.2-dev to 5.3-dev March 2, 2025 19:55
@alikon alikon changed the title [5.x][cypress] php warning [5.3][cypress] php warning Mar 2, 2025
@alikon alikon removed the PR-5.2-dev label Mar 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants