Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.0] Remove chosen #45018

Open
wants to merge 2 commits into
base: 6.0-dev
Choose a base branch
from

Conversation

dgrammatiko
Copy link
Contributor

@dgrammatiko dgrammatiko commented Feb 26, 2025

Pull Request for Issue # .

Summary of Changes

  • Remove the really outdated (and not used since 4.0) chosen.js
  • Remove the old Tags scripts that used it
  • cleanup the build tools
  • Cleanup serachtools and the cassiopeia references to chosen js and css

Testing Instructions

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@joomla-cms-bot joomla-cms-bot added NPM Resource Changed This Pull Request can't be tested by Patchtester PR-6.0-dev labels Feb 26, 2025
@Fedik Fedik added the Removal Removes functionality label Feb 27, 2025
@Fedik
Copy link
Member

Fedik commented Feb 27, 2025

I have tested this item ✅ successfully on 77d8b3e


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45018.

@brianteeman
Copy link
Contributor

Remove the old Tags scripts that used it

where

@dgrammatiko
Copy link
Contributor Author

@brianteeman I guess my comment is confusing, I mean there are 2 files (build/media_source/legacy/js/ajax-chosen.es5.js, build/media_source/legacy/js/joomla-chosen.es5.js) that depend on chosen and these are removed. Joomla 4+ doesn't use anywhere chosen thus chosen and the 2 files are removed. Also cleaned up any scripts that had chosen references

@brianteeman
Copy link
Contributor

I assumed you referred to \build\media_source\system\js\fields\tag.es5.js which appears to use chosen and is not touched by this PR

@dgrammatiko
Copy link
Contributor Author

I assumed you referred to \build\media_source\system\js\fields\tag.es5.js

That's the other part of the J3 tags that obviously I missed! Thanks

@brianteeman
Copy link
Contributor

I have tested this item ✅ successfully on 7b801be

real tests produce real results


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45018.

@laoneo laoneo added b/c break This item changes the behavior in an incompatible why. HEADS UP and removed Removal Removes functionality labels Feb 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
b/c break This item changes the behavior in an incompatible why. HEADS UP NPM Resource Changed This Pull Request can't be tested by Patchtester PR-6.0-dev
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants