Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.0] breadcrumbs unused function #44605

Merged
merged 3 commits into from
Dec 18, 2024
Merged

Conversation

brianteeman
Copy link
Contributor

@brianteeman brianteeman commented Dec 11, 2024

Updated Pull Request for original PR #33913 .

Summary of Changes

The setSeparator function has not been used in Joomla since the release of 4.0

Testing Instructions

Code review

Link to documentations

Please select:

@laoneo laoneo added the b/c break This item changes the behavior in an incompatible why. HEADS UP label Dec 12, 2024
@laoneo
Copy link
Member

laoneo commented Dec 12, 2024

@fgsw
Copy link

fgsw commented Dec 12, 2024

I have tested this item ✅ successfully on cf0a43c

Prebuilt package used.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44605.

@brianteeman
Copy link
Contributor Author

@alikon
Copy link
Contributor

alikon commented Dec 17, 2024

setting RTC cause it was successfully tested by @Quy too

@joomla-cms-bot joomla-cms-bot changed the title [6.0] breadcrumbs unused function [6.0] breadcrumbs unused function Dec 17, 2024
@joomla-cms-bot joomla-cms-bot removed b/c break This item changes the behavior in an incompatible why. HEADS UP PR-6.0-dev labels Dec 17, 2024
@alikon
Copy link
Contributor

alikon commented Dec 17, 2024

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44605.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Dec 17, 2024
@alikon alikon added b/c break This item changes the behavior in an incompatible why. HEADS UP PR-6.0-dev labels Dec 17, 2024
@Bodge-IT
Copy link

I have tested this item ✅ successfully on 2ca900c

function removed as documented


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44605.

@Bodge-IT Bodge-IT added this to the Joomla! 6.0.0 milestone Dec 18, 2024
@Bodge-IT Bodge-IT merged commit 5043379 into joomla:6.0-dev Dec 18, 2024
3 checks passed
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Dec 18, 2024
@brianteeman brianteeman deleted the patch-3 branch December 18, 2024 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
b/c break This item changes the behavior in an incompatible why. HEADS UP PR-6.0-dev
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants