Improve dark mode readability in compare view #44534
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joomla-cms-bot
added
NPM Resource Changed
|
Thank you for your contribution. Please can you ed8it the title so that it is more meaningful - especially as it will be shown in the changelog
|
|
Please change colors to match the Save / Close buttons. The white text on fluorescent green is difficult to read. |
SheikhZaeem
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #44293 .
Fixes
Fixes #44293
Summary of Changes
Fix dark mode issue in the compare view by adjusting the background color for added and removed text to be more accessible.
Testing Instructions
Actual result BEFORE applying this Pull Request
The added and removed text is not readable in dark mode.
Expected result AFTER applying this Pull Request
Added text has a green background, and removed text has a red background, both readable in dark mode.