-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[5.2] Add legacy message to content modules #44366
base: 5.2-dev
Are you sure you want to change the base?
Conversation
I have tested this item ✅ successfully on 0a54475 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44366. |
1 similar comment
I have tested this item ✅ successfully on 0a54475 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44366. |
Co-authored-by: Quy <[email protected]>
Co-authored-by: Quy <[email protected]>
I am not in favour of such a public deprecation notice.
This is a change for changes sake and benefits no one. |
Maybe it's an English language issue and instead of writing deprecated it would be better to write legacy |
And it should go into 5.3. |
…cms into 5.2/deprecate-modules
Missing
|
@Quy For now, the new module can group and display archive articles, but not a list of months (correct me if I'm wrong and missed this). |
Sorry I have not used the Articles module yet to answer your question. Based on PR #43738 description, this is one of the modules being replaced. |
Deprecated and legacy convey two distinctly different meanings. Deprecated means the "thing" (function, API, feature) is still in the code and available but will be removed in future versions and better alternatives exist, that continued use will at some point cause problems. Legacy means the "thing" is still in active use, works but may be outdated, needs to be maintained for compatibility, isn't necessarily bad or discouraged, and may be difficult to replace. So in simple terms If you want to make usage clear then say (Removed in future releases) This conveys the need to not start using it. Whereas legacy does not convey the discouragement needed. |
Summary of Changes
With #43738 we have a "one for all" module for certain content modules. This PR adds an info that users should use the new module instead.
Testing Instructions
Actual result BEFORE applying this Pull Request
No messages
Expected result AFTER applying this Pull Request
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed