Refactoring #53
Open
Refactoring #53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Llewellynvdm
reviewed
Dec 5, 2021
| // Get a new Uri object focusing the api url and given path. | ||
| $uri = new Uri($this->options->get('api.url') . $path); | ||
|
|
||
| if ($this->options->get('gh.token', false)) |
There was a problem hiding this comment.
Will this change not override all other headers that where set by the user.
Llewellynvdm
reviewed
Dec 5, 2021
| $this->options['timeout'] = 120; | ||
| } | ||
|
|
||
| if ($this->options->get('gh.token', false)) |
There was a problem hiding this comment.
The previous path only set the Authorization if it was not set... now its being set irrespective of that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Before this change,
AbstractGithubObject::fetchUrl()altered the HTTP client on the fly to add header data. Since the header data is not part of the URL, this undocumented side effect is just wrong.Now, the options are propagated to the client in the constructor, where it should be.
Testing Instructions
See
GithubObjectTest::testFetchUrlToken().Documentation Changes Required
No.