(Fix) broken tarballs download to inputs dir #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The -O flag holds precedence over the -P flag and defaults the location to ./<-O value>. This commit places the 'inputs' dir directly into the -O flag value and removes the -P flag.
|
Addresses part of the issue flagged in #14 (comment) as well |
Replaced the sourceforge location (that now throws a 404 error) with a version hosted on the bitcoin repo. See this issue for more details: https://github.com/bitcoin/bitcoin/issues/21416\#issuecomment-803286481
vindard
changed the title
jonatack
reviewed
Apr 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
osslsigncode-2.0.tar.gzThe
-Oflag holds precedence over the-Pflag and defaults the location to./<-O value>. This fix places the 'inputs' dir directly into the-Oflag value and removes the-Pflag for theosslsigncode-2.0.tar.gzfile.osslsigncode-1.7.1.tar.gzOriginal link is now broken but there is now a version hosted on the
bitcoinrepo (see bitcoin/bitcoin#21416 (comment))