Repository navigation
fix(worktree): slugify the worktree name for docker compose - #455
Merged
Merged
Conversation
JorickPepin
force-pushed
the
fix-worktree-name-slug
branch
from
October 15, 2026 12:48
b143d65 to
f0d039a
Compare
lyrixx
reviewed
Oct 15, 2026
lyrixx
reviewed
Oct 15, 2026
JorickPepin
force-pushed
the
fix-worktree-name-slug
branch
from
October 15, 2026 13:13
f0d039a to
e68c9eb
Compare
pyrech
approved these changes
Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
When a project lives in a directory with dots in its name (e.g.
my.project), a worktree created next to it usually gets a name likemy.project-my-feature. In that worktree, every Castor task that calls Docker Compose, likecastor start, fails right away:The worktree name is appended as is to the Compose project name, and Compose rejects the dots.
Fix
The worktree name is now slugified: every run of characters outside
[a-z0-9]becomes a-. The worktree above now runs asapp-wt-my-project-my-feature.Warning
Underscores are replaced too: an existing worktree named
my_featurebecomesmy-feature, so it gets new volumes and ports. Runcastor stopin such worktrees before pulling this change, otherwise the old stack keeps running orphaned.