[JorickPepin]

Changes

• docker_compose_run() and docker_compose_exec() no longer change the context: internal tasks (install, qa, start…) get Castor's default context back, as before Refactor how we use run() docker command #426 (colors, Ctrl-C, output capture, a failing step stops the task)
• castor builder -- … gets a TTY in a terminal, and the forwarded stdin otherwise (CI, pipes, redirections), so the fix from Really fix the builder command when no TTY is available #407 still holds
• castor postgres -- … stays non-interactive, with stdin forwarded
• A CI step checks the TTY and stdin of castor builder, with and without a terminal

How to test

# From a terminal: bool(true), with colors
castor builder -- php -r 'var_dump(stream_isatty(STDOUT));'

# Piped output: bool(false)
castor builder -- php -r 'var_dump(stream_isatty(STDOUT));' | cat

# Piped input reaches the container
echo hello | castor builder -- cat

# Ctrl-C during `castor qa` stops the whole task
castor qa

[lyrixx]

Thanks @JorickPepin! The colors are back indeed, but giving /dev/tty to every docker_compose_run() / docker_compose_exec() call has side effects on the internal tasks (install, qa, init…). Tested in a pseudo-terminal:

• Ctrl-C goes to the container, and since the helpers force withAllowFailure(), the task carries on: castor qa needs one Ctrl-C per tool, and castor start continues after an interrupted composer install.
• $process->getOutput() is empty in a terminal, but not in CI.
• Without a controlling terminal (nested castor, setsid), every container command fails to start.
• An input passed by the caller is kept in a terminal, but replaced by STDIN otherwise.

The root cause predates this PR: #426 moved the policy of the castor builder -- … proxy into the shared helpers. I suggest undoing that instead:

• the helpers don't touch the context anymore: internal tasks get Castor's default context back (PTY: colors, Ctrl-C, output capture, a failing step stops the task), like before Refactor how we use run() docker command #426;
• builder() alone decides, with Castor's own detection: toInteractive() in a terminal, the forwarded stdin otherwise;
• castor pg -- … stays non-interactive, as its docblock says (no pager).

Patch on top of your branch (git apply):

diff --git a/.castor/docker.php b/.castor/docker.php
index e0106bc..f9acfb7 100644
--- a/.castor/docker.php
+++ b/.castor/docker.php
@@ -255,6 +255,12 @@ function builder(#[AsArgsAfterOptionEnd] array $params = []): int
 {
     $context = context()->withEnvironment($_ENV + $_SERVER);
 
+    // Behave like the command run by hand: a TTY in a terminal (colors,
+    // prompts), the forwarded stdin otherwise (CI, pipes, redirections)
+    $context = $context->supportsInteraction()
+        ? $context->toInteractive()
+        : $context->withInput(STDIN)->withAllowFailure();
+
     return (int) docker_compose_run($params, $context)->getExitCode();
 }
 
@@ -520,16 +526,6 @@ function docker_compose(array $subCommand, ?Context $c = null, array $profiles =
     return run($command, context: $c, callback: $callback);
 }
 
-// Keep the TTY in a terminal so tools keep their colors, drop it when piped (CI, `castor postgres < dump.sql`)
-function command_context(Context $c): Context
-{
-    if (!$c->quiet && stream_isatty(STDIN) && stream_isatty(STDOUT)) {
-        return $c->withTty()->withAllowFailure();
-    }
-
-    return $c->withTty(false)->withPty(false)->withInput(STDIN)->withAllowFailure();
-}
-
 /**
  * @param list<string> $params
  */
@@ -572,7 +568,6 @@ function docker_compose_run(
         $params = ['bash'];
         $c = $c->toInteractive();
     } else {
-        $c = command_context($c);
         $params = array_map(escapeshellarg(...), $params);
     }
 
@@ -602,7 +597,6 @@ function docker_compose_exec(
         $params = ['bash'];
         $context = $context->toInteractive();
     } else {
-        $context = command_context($context);
         $params = array_map(escapeshellarg(...), $params);
     }
 
diff --git a/.castor/postgres.php b/.castor/postgres.php
index 60fc2e6..528a1bb 100644
--- a/.castor/postgres.php
+++ b/.castor/postgres.php
@@ -40,5 +40,5 @@ function client(#[AsArgsAfterOptionEnd] array $params = []): int
         $params = ['-c', implode(' ', $params)];
     }
 
-    return (int) docker_compose_exec([...$command, ...$params], service: 'postgres')->getExitCode();
+    return (int) docker_compose_exec([...$command, ...$params], context()->withInput(STDIN)->withAllowFailure(), service: 'postgres')->getExitCode();
 }
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index c2eb379..de5cdf1 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -122,8 +122,14 @@ jobs:
                   set -e
                   set -o pipefail
 
-                  # A terminal gets a TTY (for colors), a pipe does not
-                  script -qec "castor builder -- php -r 'exit(stream_isatty(STDOUT) ? 0 : 1);'" /dev/null
+                  # In a terminal (emulated by script), the command gets a TTY (for colors).
+                  # CI is unset, as Castor never considers it as interactive
+                  env -u CI script -qec "castor builder -- php -r 'exit(stream_isatty(STDOUT) ? 0 : 1);'" /dev/null
+                  # Even in a terminal, a pipe on stdout or stdin reaches the container
+                  env -u CI script -qec "castor builder -- php -r 'echo stream_isatty(STDOUT) ? \"tty\" : \"pipe\";' | cat" /dev/null | grep -w pipe
+                  env -u CI script -qec "echo hello | castor builder -- cat" /dev/null | grep -w hello
+
+                  # Without a terminal
                   castor builder -- php -r 'exit(stream_isatty(STDOUT) ? 1 : 0);' | cat
                   echo hello | castor builder -- cat | grep -x hello

Checked locally in a pseudo-terminal:

• castor builder -- php -r 'var_dump(stream_isatty(STDOUT));' gives bool(true) in a terminal, bool(false) when piped, and piped stdin reaches the container;
• Ctrl-C stops a multi-step task, and so does a failing step;
• exit codes are propagated (castor builder -- bash -c 'exit 3' gives 3, Ctrl-C gives 130);
• the CI step passes with CI=true and fails on main;
• PHP-CS-Fixer and PHPStan are green.

Two limits remain for castor builder -- … in a terminal, both coming from Castor's TTY mode: 2>file is ignored, and it fails without a controlling terminal (Castor checks is_writable('/dev/tty'), which passes even when /dev/tty can't be opened). The second one will go away with jolicode/castor#908: the builder then falls back to the forwarded stdin. More on all this in jolicode/castor#907.

[JorickPepin]

Thanks a lot @lyrixx for the testing and the patch! I applied it as is, squashed everything into a single commit and updated the PR description.

[lyrixx]

Awesome. Thanks!