Skip to content

modifying title - #31

Open
jalanvanshika wants to merge 1 commit into
jolicode:gh-pagesfrom
jalanvanshika:gh-pages
Open

modifying title#31
jalanvanshika wants to merge 1 commit into
jolicode:gh-pagesfrom
jalanvanshika:gh-pages

Conversation

@jalanvanshika

Copy link
Copy Markdown

No description provided.

@damienalexandre

Copy link
Copy Markdown
Member

Thank you for your contribution!

I recommend you attach some description and screenshot when you send this kind of graphic suggestion to a project, this can help a lot maintainers!

I like the new style you propose, but the initial state is strange (when the title is empty):

Initial state (when loading the page)

image

Documentation state (when hover on properties)

image

Do you think there is a way to handle this more gracefully? Maybe by adding a default title? I suggest Welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants