Fixes the issue #207: “months don't always snap to their edge” #218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looking at your implementation, this is the best results I could get without touching a lot of stuff. With this fix the months always snap to their edge.
The issue: if you place arrows in your calendar to call loadPreviousPageWithAnimation and loadNextPageWithAnimation, the bug appears when the user taps on an arrow multiple times, without letting the previous animation to finish.
I pushed two branches with modifications on your example so you can reproduce the error easily:
Checkout this one to reproduce it : https://github.com/palcalde/JTCalendar/tree/noFix
Checkout this one to see how the fix works: https://github.com/palcalde/JTCalendar/tree/withFix
Hope this helps.