Fixed iPad issue where you cannot switch between a full-screen image and video#103
Open
deanc wants to merge 2 commits intojohnpolacek:masterfrom
deanc:ipad-fix
Open
Fixed iPad issue where you cannot switch between a full-screen image and video#103deanc wants to merge 2 commits intojohnpolacek:masterfrom deanc:ipad-fix
deanc wants to merge 2 commits intojohnpolacek:masterfrom
deanc:ipad-fix
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
You cannot interact with a hidden HTML5 video in a callback on iPad, even if you attempt to show the video at the beginning of the callback code.
A pseudo-example code would be:
This would not work. This PR fixes this by changing the behaviour to hide a video or poster using opacity, which means you can still interact with it even if it's not visible, or about to be made visible.