Skip to content

refactor: consolidate shared helpers - #179

Closed
DhruvGarg111 wants to merge 2 commits into
johnnichev:mainfrom
DhruvGarg111:fix/147-small-consolidations
Closed

DhruvGarg111 wants to merge 2 commits into
johnnichev:mainfrom
DhruvGarg111:fix/147-small-consolidations

Conversation

@DhruvGarg111

@DhruvGarg111 DhruvGarg111 commented Jul 19, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Centralize toolbox HTTP defaults, user-agent, and API error formatting.
  • Share PII detection patterns and fix the evaluator email regex.
  • Align NumPy cosine behavior across vector stores and consolidate graph interrupt checkpoint IDs.

Verification

  • ruff format and ruff check --fix on changed files
  • 363 focused tests passed
  • Full non-E2E suite is blocked by an unrelated timing-sensitive analytics assertion

Closes #147

Share toolbox HTTP defaults and API error formatting, and consolidate PII patterns used by guardrails and evaluators.
Align NumPy cosine behavior between vector stores and remove duplicated graph interrupt checkpoint ID creation.
@johnnichev
johnnichev self-requested a review July 23, 2026 20:07
@DhruvGarg111 DhruvGarg111 closed this by deleting the head repository Sep 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Small consolidations: toolbox HTTP helpers, PII regex bug, cosine epsilon, graph checkpoint

1 participant