Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Makefile for webapi direct client #68

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mika76
Copy link

@mika76 mika76 commented Nov 18, 2020

Changed powershell start-process to dotnet exec so that it works on a mac
Changed some echo text

Changed powershell start-process to dotnet exec so that it works on a mac
Changed some echo text
@mika76
Copy link
Author

mika76 commented Nov 18, 2020

I was just playing with this so I don't know what else I will run into yet - but trying to run this on a mac hit the hurdle of powershell start-process not working (even though I have powershell for mac) - one thing I'm not sure about is the working directory argument - it seems dotnet exec does not have that. Oh and I haven't checked the other templates yet.

@johnazariah
Copy link
Owner

Hi Mika

Sorry - I've been busy with an international house move so I wasn't able to monitor this project.

I'm happy to accept your PR but I can't see the logs any more...can you please help me with that?

Also it looks like the F# webapi template is broken by your fix - can you do the same change for F# as you did for C#?

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants