Update LinkedList0.py#133
Open
nikitapandeyy wants to merge 1 commit intojoeyajames:masterfrom
Open
Conversation
In the find method, the function is returning the data instead of the node that contains the data. This can be problematic if the data appears multiple times in the linked list, as it will only return the first occurrence. The method should return the node that contains the data, or None if the data is not found. In the remove method, if the data is not found in the linked list, the method returns False. This is not an ideal way to handle the situation, as it could lead to confusion if the user thinks that the data has been removed when it has not. It would be better to raise an exception, such as a ValueError, to indicate that the data is not in the linked list.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the find method, the function is returning the data instead of the node that contains the data. This can be problematic if the data appears multiple times in the linked list, as it will only return the first occurrence. The method should return the node that contains the data, or None if the data is not found.
In the remove method, if the data is not found in the linked list, the method returns False. This is not an ideal way to handle the situation, as it could lead to confusion if the user thinks that the data has been removed when it has not. It would be better to raise an exception, such as a ValueError, to indicate that the data is not in the linked list.