Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prototype on how ftp could show more info #45

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

MarcoMartins86
Copy link

Hi Joel,

Please don't accept this pull request, it just to show you what I think it could be an improvement on the ftp menu with a ftp server library I've made based on the ftpd code (it will still have problems like when no network is present, I didn't protect it for now).

Not sure if I should continue investing time on this if you don't like it. Tell me your opinion when you get some time.

Also, for now test it while downloading/uploading a file at a time, although ftp will work, I just made code to display the transfer info of one file.

Thanks,
Marco Martins

@joel16
Copy link
Owner

joel16 commented Feb 26, 2019

Hey! thanks for the PR. Could you perhaps send a build over for me to test. I can take a look then and let you know.

@MarcoMartins86
Copy link
Author

Sure, I have uploaded it here

@joel16
Copy link
Owner

joel16 commented Mar 3, 2019

Well for some reason it doesn't show up my sd contents from WinSCP.

@MarcoMartins86
Copy link
Author

Thank you, I will check on that...I was using FileZilla, it should work for you also if you want to try in the meanwhile.

@MarcoMartins86
Copy link
Author

This version should work with WinSCP.

@joel16
Copy link
Owner

joel16 commented Mar 10, 2019

That build works. I like how it shows the bytes (MB) remaining, but it seems to blinking instead of showing it constantly. If you can fix that, then I wouldn't mind making this change.

@MarcoMartins86
Copy link
Author

Thank you for your feedback, the reason for the blinking is because during some GUI cycles there were no data sent/received but I already thought in a way to fix that.
Also, when sending files from 3DS we know the file size but when receiving we only know the MB that we currently have due to FTP protocol not negotiating the file size beforehand.
Moreover, GUI should be more responsive since all FTP operations are being done in another thread.

Since you have given green light I will improve what's done and I will let you know afterward. I will also make the source code available on my Github page at that point.

@xy172
Copy link

xy172 commented May 31, 2020

Any updates? Id really like this feature.

@MarcoMartins86
Copy link
Author

Sorry for the delay but I had a catastrophic hard drive failure on my dev machine, luckily I had already most of the code committed to GitHub.
I think I fixed most of the issues with this version.
I still need to implement the list of connected clients.
When sending we can show the percentage since we know both the file size and the current position.
When receiving we can only show the amount of data received since we don't know the original file size.
Right now due to how things are exposed on screen only two simultaneous transfers are shown.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants